Fix per-user Last.fm integration - #80
Closed
Darep wants to merge 23 commits into
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Darep
force-pushed
the
fix/per-user-lastfm
branch
from
August 9, 2026 19:46
e1b303b to
6d1699e
Compare
Darep
force-pushed
the
fix/per-user-lastfm
branch
from
August 29, 2026 20:12
6d1699e to
858a75a
Compare
Darep
commented
Aug 30, 2026
Comment on lines
+27
to
+28
| /** Increments whenever a new track playback starts, including repeats */ | ||
| playbackInstance: number; |
Owner
Author
There was a problem hiding this comment.
"instance" sounds like it's an instance of a playback while this is a counter. Right?
My suggestion:
Suggested change
| /** Increments whenever a new track playback starts, including repeats */ | |
| playbackInstance: number; | |
| /** Increments whenever a new track playback starts, including repeats. Used by Last.fm to keep track of new plays. */ | |
| playbackCount: number; |
Also, do we have comprehensive tests to make sure this is incremented correctly in every situation?
Owner
Author
There was a problem hiding this comment.
Random irrelevant interesting question, no need to act: Can this overflow over time…? If someone keeps player open for a LONG TIME?
Darep
commented
Aug 30, 2026
| } | ||
|
|
||
| return { | ||
| playbackInstance: isResume ? state.playbackInstance : state.playbackInstance + 1, |
Owner
Author
There was a problem hiding this comment.
Let's inline the isResume, easier to read the flow of the code:
Suggested change
| playbackInstance: isResume ? state.playbackInstance : state.playbackInstance + 1, | |
| // Increase playback count when we are playing new jams. | |
| playbackCount: state.state === 'paused' ? state.playbackCount : state.playbackCount + 1, |
Darep
commented
Aug 30, 2026
Comment on lines
+18
to
+22
| Username string `json:"username"` | ||
| Password string `json:"password"` | ||
| LastFMUsername string `json:"lastfm_username,omitempty"` | ||
| LastFMSession string `json:"lastfm_session,omitempty"` | ||
| LastFMToken string `json:"lastfm_token,omitempty"` |
Owner
Author
There was a problem hiding this comment.
Suggested change
| Username string `json:"username"` | |
| Password string `json:"password"` | |
| LastFMUsername string `json:"lastfm_username,omitempty"` | |
| LastFMSession string `json:"lastfm_session,omitempty"` | |
| LastFMToken string `json:"lastfm_token,omitempty"` | |
| Username string `json:"username"` | |
| Password string `json:"password"` | |
| LastFMUsername string `json:"lastfm_username,omitempty"` | |
| LastFMSession string `json:"lastfm_session,omitempty"` | |
| LastFMToken string `json:"lastfm_token,omitempty"` |
Darep
commented
Aug 30, 2026
Darep
commented
Aug 30, 2026
Darep
commented
Aug 30, 2026
| }), | ||
| }).catch((error: unknown) => { | ||
| console.error(`Could not scrobble ${song.artist} — ${song.title}`, error); | ||
| if (error instanceof ApiError && error.status === 409) void mutate('/api/lastfm'); |
Owner
Author
There was a problem hiding this comment.
What are we doing here and why? Add comment, and also add { }
Darep
commented
Aug 30, 2026
Darep
commented
Aug 30, 2026
|
|
||
| export const LastFMScrobbler = () => { | ||
| const { data: lastFM } = useLastFM(); | ||
| const scrobbledInstances = useRef(new Map<string, number>()); |
Owner
Author
There was a problem hiding this comment.
Let's simplify this, we won't need multi-user in-memory support – we can easily reload the page on logout (and we should, for memory-security, but let's fix that separately).
Suggested change
| const scrobbledInstances = useRef(new Map<string, number>()); | |
| const scrobbleCounter = useRef<number>(); |
Darep
commented
Aug 30, 2026
Darep
commented
Aug 30, 2026
| const [changingPassword, setChangingPassword] = useState(false); | ||
| const { data: lastFM } = useLastFM(); | ||
| const [busy, setBusy] = useState(false); | ||
| const [error, setError] = useState(''); |
Owner
Author
There was a problem hiding this comment.
Rename:
Suggested change
| const [error, setError] = useState(''); | |
| const [lastfmError, setLastfmError] = useState(''); |
Darep
commented
Aug 30, 2026
Co-authored-by: AJ Kovalainen <ajk@ajk.fi>
Darep
commented
Aug 30, 2026
| http.Error(w, "Invalid password", http.StatusBadRequest) | ||
| return | ||
| } | ||
|
|
Owner
Author
There was a problem hiding this comment.
Undo this removal of a newline.
Darep
commented
Aug 30, 2026
Owner
Author
|
Squashed to master manually, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run typechecknpm run builddocker build -f Dockerfile.hub -t beatstream-lastfm-check .docker run --rm beatstream-lastfm-test go test ./...Repository-wide frontend lint still reports pre-existing violations outside this change.