Repository navigation
Document Location headers for created REST resources - #369
Conversation
Specify the shared JSON creation response header and the canonical EPerson URI returned after successful account creation.
|
@saschaszott the review feedback has been addressed in 3e89c41 — the repository-wide 201/Location contract is now in README.md, and all three EPerson POST variants in epersons.md document the returned Location URI. The companion code PR DSpace/DSpace#12848 already has two approvals (yours and @MMilosz's) and is only waiting on this contract PR, so a re-review here would be much appreciated. Thanks! |
|
@pratyushsinghal7 , I am not sure whether my concern has been addressed. Your change to the |
There was a problem hiding this comment.
👍 Thanks @pratyushsinghal7 ! This looks "good enough" to me, especially since the new Location header is now mentioned in the general README.md.
I do think we could follow this PR up with additional cleanup work to document every 201 that now returns a Location header, but this is good enough for now.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-369-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-369-to-dspace-8_x
git switch --create backport-369-to-dspace-8_x
git cherry-pick -x 07e9e1e0adbdb2d5b2fac12014ebc6e50c9a0d0c 3e89c412342c15e2c2830a055a85046352e3afc8 |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
References
Description
Document that successful JSON collection-resource creation returns
201 Createdwith an absoluteLocationheader for the created resource.The EPerson creation contract now includes the concrete canonical URI shape returned by
POST /api/eperson/epersons.Validation
git diff --check