Open
Conversation
Member
|
@joris997 can you merge |
Pedro-Roque
requested changes
Jul 7, 2023
Member
Pedro-Roque
left a comment
Pedro-Roque
left a comment
There was a problem hiding this comment.
@joris997 please check these updates
| RUN make -j4 | ||
| RUN sudo make install | ||
|
|
||
| RUN export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/home/opencv/opencv-4.2.0/build/lib |
Member
There was a problem hiding this comment.
@joris997 if you want to set this env variable, you should use the tag ENV, as in
ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/home/opencv/opencv-4.2.0/build/lib"
| include | ||
| ${rclcpp_INCLUDE_DIRS} | ||
| ${EIGEN3_INCLUDE_DIR} | ||
| ${ff_common_INCLUDE_DIRS} |
Member
There was a problem hiding this comment.
Why do you need this inside ff_common?
| include | ||
| ${rclcpp_INCLUDE_DIRS} | ||
| ${LUAJIT_INCLUDE_DIR} | ||
| ${ff_common_INCLUDE_DIR} |
Member
There was a problem hiding this comment.
I don't think this is needed anymore after fixing ff_common
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to incorporate Ana's OpenCV4 implementation with some quick fixes and installation instructions for users (as a text file, this could later be incorporated for the docker startup)