update: Increase complexity x2. Add randomization in duration of the test. Suppress warnings.#16
update: Increase complexity x2. Add randomization in duration of the test. Suppress warnings.#16IgorPelevanyuk wants to merge 3 commits intoDIRACGrid:masterfrom
Conversation
…time, but produce more accurate results.
…all to deal with low accuracy of os.times()
|
I did not look at the implementation details, but just a general remark: LHCb relies heavily on db12 to asses the job duration, and the correlation between db12 and our application is important to preserve. So if changes to the output results are introduced, we will need to find a more "parametrizable way" to do |
|
Considering increased complexity - results would be just more accurate, since test will run twice more time. |
aldbr
left a comment
There was a problem hiding this comment.
-
For the randomization and 2x complexity: see my comments in #15 (comment)
-
For the
factors.jsonfile, we have been using python3.11 for a few years and haven't noticed any issue even though there was no correction.
I see 2 solutions: -
we make the study to get the correction factors and we apply them (does it make sense now?). But we would need to do it every time we update the python version, which is cumbersome.
-
we remove this
factors.jsonfile and we stop relying on it. Here it means that we will drift away the original scores without noticing it (though in the current state it's already the case). On a higher level point of view, we might consider replicating the code in a language like Rust to avoid that kind of issue in the future.
Ideally, it would be better to separate these 2 aspects in different PRs I think.
Suppress #9
Fix #15