NRF2-706 Add service-to-service API keys to the stack#2
Open
muthukswamy wants to merge 2 commits into
Open
Conversation
Wire BACKEND_API_KEY and IMPACT_ASSESSOR_API_KEY into compose.yml and bump submodule pointers for the new service-to-service API key authentication across backend, frontend and impact-assessor.
Update submodule pointers to include the package-lock.json reconciliation in nrf-backend and nrf-frontend.
Contributor
|
The PR description mentions an update to cdp-tenant-config - wouldn't the API keys be new secrets though? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parent-repo glue for the NRF2-706 service-to-service authentication change. Wires the API keys into the Tilt compose stack and bumps the submodule pointers.
Changes
compose.yml— addsBACKEND_API_KEYandIMPACT_ASSESSOR_API_KEYto thebackend,frontendandimpact-assessorservices (local dev values).backend,frontend,impact-assessorandjourney-testssubmodule pointers to the NRF2-706 commits.Test plan
tilt up— full stack healthycurl http://localhost:3001/quotes/NRF-000001→ 401; withx-api-key→ 200/404curl -X POST http://localhost:8085/check-boundary→ 401Deployment
Real
BACKEND_API_KEY/IMPACT_ASSESSOR_API_KEYvalues must be added per environment incdp-tenant-configbefore the service PRs are deployed. The local-dev values here are placeholders only.Related PRs