Fix Routing's methods_ Bitmask Overflow#1169
Merged
gittiver merged 3 commits intoCrowCpp:masterfrom Mar 29, 2026
Merged
Conversation
…lue to represent it
Methods have more than 32 values
gittiver
requested changes
Mar 27, 2026
Member
gittiver
left a comment
gittiver
left a comment
There was a problem hiding this comment.
could you resolve the comments?
Contributor
Author
|
Resolved |
gittiver
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods have more than 32 values which means we can't use a 32 bit value to represent it.
If someone attempts to use an
HTTPMethodtowards the end of the enum set with this mask, it will overflow and will act as if a differentHTTPMethodwas used.