concore inspect and concore watch print an error but still exit with 0, so scripts and CI think they worked.
Repro:
concore inspect README.md; echo $?
concore inspect README.md --json; echo $?
concore watch README.md; echo $?
Output:
Not a valid GraphML file
0
{"error": "Not a valid GraphML file"}
0
Error: 'README.md' is not a directory
0
Expected: non-zero exit on these errors, like validate does after #303.
Actual: the error paths in inspect.py and watch.py just return, and the CLI wrapper only exits 1 when an exception is raised. Same for the Inspection failed catch in _inspect_rich.
Tested on dev at 32951ab
concore inspectandconcore watchprint an error but still exit with 0, so scripts and CI think they worked.Repro:
Output:
Expected: non-zero exit on these errors, like
validatedoes after #303.Actual: the error paths in
inspect.pyandwatch.pyjustreturn, and the CLI wrapper only exits 1 when an exception is raised. Same for theInspection failedcatch in_inspect_rich.Tested on dev at 32951ab