Skip to content

Simplify internal graph checks and Steiner witness extraction - #1158

Merged
GiggleLiu merged 2 commits into
mainfrom
refactor/reuse-petgraph-checks
Sep 18, 2026
Merged

GiggleLiu merged 2 commits into
mainfrom
refactor/reuse-petgraph-checks

Conversation

@isPANN

@isPANN isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the private articulation-point DFS with petgraph connectivity and articulation-point checks.
  • Replace private union-find implementations in forest partitioning and PERT network evaluation with the existing petgraph dependency.
  • Extract prize-collecting Steiner forest witnesses in one edge scan, without repeatedly cloning the target edge list.
  • Preserve public APIs and feasibility semantics, including empty graphs, disconnected graphs, loops, repeated edges, and zero-prize connector vertices.
  • Six files, 57 added lines and 134 removed lines; based directly on main.

Verification

  • Full workspace all-feature unit and integration tests: 6,479 passed; 2 existing ignored.
  • Library coverage run includes the graph checks and Steiner closed-loop tests.
  • Changed-line coverage: 100% of 47 measured lines.
  • Workspace all-target all-feature Clippy with warnings denied, formatting, and diff whitespace checks passed.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.92%. Comparing base (7dd5fcd) to head (4c2b8eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   95.93%   95.92%   -0.01%     
==========================================
  Files        1074     1074              
  Lines      132106   132060      -46     
==========================================
- Hits       126730   126684      -46     
  Misses       5376     5376              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isPANN isPANN changed the title Reuse petgraph algorithms in graph feasibility checks Simplify internal graph checks and Steiner witness extraction Sep 17, 2026

@GiggleLiu GiggleLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review: petgraph replacements preserve the K2 convention and cycle detection; merged extractor loop is equivalent. make check passes locally on the merged state. Approving as-is.

@GiggleLiu
GiggleLiu merged commit d01ada5 into main Sep 18, 2026
9 checks passed
@isPANN
isPANN deleted the refactor/reuse-petgraph-checks branch September 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants