Conversation
biome.json declared https://biomejs.dev/schemas/2.4.13/schema.json while the installed CLI is 2.5.8, so editors validated the config against a schema two minors behind. Pointing it at 2.5.8 also clears one of the two config notices biome check emits. The surviving notice is real and separate: 'recommended' is deprecated in favour of 'preset' as of Biome 2.5. Recovered from an unpushed commit left in .claude/worktrees/lockfile-dedupe by an earlier session, verified still valid before cherry-picking.
biome.json's files.includes never listed **/*.mjs, so 38 tracked files went unlinted and unformatted since the config was written, while both the pre-push chain and the CI biome job went green over them. 36 of the 41 findings were mechanical; each regex rewrite was verified individually rather than trusted to --fix, since these files assert on indented YAML, Dockerfile, and Ruby where the space count is the assertion. Four of the remaining five are false positives suppressed inline with a reason. The fifth was a real bug: release-next-version.mjs accepted a bare ZWJ or variation selector as a gitmoji, so an invisible prefix inferred a minor or patch release against the file's own only-emoji contract. Fixed with a pictographic-base requirement and two regression tests. Closes #297.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 22 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 participants
Routine
dev/v1.7tomainpromotion. Two changes since the last one.#301 — biome now covers the 38 tracked
.mjsfiles.biome.json'sfiles.includesnever listed**/*.mjs, so nearly all ofscripts/had gone unlinted and unformatted since the config was written, while both the pre-push chain and the CIbiomejob went green over it. Closes #297.The part worth reading: one of the 41 findings was a real bug in release tooling.
release-next-version.mjsdecides whether a commit counts as patch, minor, or major, and its legacy-gitmoji prefix accepted a bare zero-width joiner or variation selector as if it were an emoji, so an invisible prefix bought a release level against the file's own only-emoji contract. Reachable the whole time; the lint that points at it had simply never run on the file. Fixed with a pictographic-base requirement plus two regression tests.The other four lint suppressions are genuine false positives where biome's suggested fix would break the code (
ReferenceErrorin two, a syntax error in a third). All suppressed inline with reasons rather than by relaxing rules repo-wide.#300 —
biome.json$schemasynced from 2.4.13 to the installed 2.5.8.Verification
node --testcases pass, up from 187.biome check .at baseline: the two pre-existingnoImgElementwarnings instar-history.tsx, unchanged.qlty checkquota failure.Reconcile-back merge follows immediately.