Enhanced confirmation dialog for deleting product groups#581
Merged
Soare-Robert-Daniel merged 3 commits intodevelopmentfrom Apr 28, 2026
Merged
Enhanced confirmation dialog for deleting product groups#581Soare-Robert-Daniel merged 3 commits intodevelopmentfrom
Soare-Robert-Daniel merged 3 commits intodevelopmentfrom
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
pr-checklist-complete
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the admin “delete field group(s)” confirmation experience by including selected group names in the dialog and adjusting popup styling to better communicate destructive actions (issue #666).
Changes:
- Adds group name metadata to the field-group list checkboxes so JS can reference the selected names.
- Updates the bulk-delete confirmation flow to interpolate selected group name(s) into the popup title.
- Tweaks shared popup UI styling (title size and confirm button colors).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| templates/admin/existing-meta.php | Adds data-name to group checkbox inputs for later use in confirmation UI. |
| js/admin/ppom-meta-table.js | Builds a confirmation title containing selected group name(s) before executing bulk delete. |
| css/ppom-admin.css | Updates shared popup title size and confirm button styling. |
| classes/fields.class.php | Changes localized popup confirmation title string to include a %s placeholder for the group name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1403
to
+1409
| .ppom-popup-actions .ppom-btn-confirm { | ||
| background-color: #ff0f0f; | ||
| } | ||
|
|
||
| .ppom-popup-actions .ppom-btn-confirm:hover { | ||
| background-color: #ef6060; | ||
| } |
Comment on lines
1362
to
1365
| .ppom-popup-title { | ||
| font-size: 2.5em; | ||
| font-size: 1.5em; | ||
| margin: 0; | ||
| line-height: 1.3; |
Contributor
|
@girishpanchal30; can we also add here and E2E for it? It should test both the actions along with the title check. |
Contributor
Author
|
@Soare-Robert-Daniel I have added test cases for it. Please check it and let me know if any changes are needed. Thanks! |
Soare-Robert-Daniel
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced confirmation dialog for deleting product groups.
Will affect visual aspect of the product
YES
Screenshots
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/ppom-pro/issues/666