PR needing review page should use create date not update date - #1966
PR needing review page should use create date not update date#1966LonMcGregor wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
illicitonion
left a comment
There was a problem hiding this comment.
I've been modelling this as "time spent waiting" rather than "time since it was created"...
Would a best of both worlds be to be checking label transitions? i.e. "When was Needs Review last added when before it either didn't have any relevant label, or had the label Reviewed"?
I don't mind making this change as-is if it's simpler and useful, but I suspect "I opened a PR a long time ago but only just acted on feedback and re-requested review" is a more common occurrence than "I toggled the Needs Review label because I got frustrated"

Only using the most recent update date gives a false impression of our review status.
This is a problem if a trainee has an old review but they toggled the "needs review" label in an attempt to get our attention, as I saw happen recently.
We should always use the oldest date here.
Thoughts?