Skip to content

PR needing review page should use create date not update date - #1966

Open
LonMcGregor wants to merge 1 commit into
mainfrom
lm-pr-review-fix-2
Open

PR needing review page should use create date not update date#1966
LonMcGregor wants to merge 1 commit into
mainfrom
lm-pr-review-fix-2

Conversation

@LonMcGregor

@LonMcGregor LonMcGregor commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Only using the most recent update date gives a false impression of our review status.

This is a problem if a trainee has an old review but they toggled the "needs review" label in an attempt to get our attention, as I saw happen recently.

We should always use the oldest date here.

Thoughts?

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 9936683
🔍 Latest deploy log https://app.netlify.com/projects/cyf-curriculum/deploys/6a67724851d44f000860fe55
😎 Deploy Preview https://deploy-preview-1966--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit 9936683
🔍 Latest deploy log https://app.netlify.com/projects/cyf-common/deploys/6a6772482ad5700007f89951
😎 Deploy Preview https://deploy-preview-1966--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@LonMcGregor
LonMcGregor marked this pull request as ready for review July 27, 2026 15:01

@illicitonion illicitonion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been modelling this as "time spent waiting" rather than "time since it was created"...

Would a best of both worlds be to be checking label transitions? i.e. "When was Needs Review last added when before it either didn't have any relevant label, or had the label Reviewed"?

I don't mind making this change as-is if it's simpler and useful, but I suspect "I opened a PR a long time ago but only just acted on feedback and re-requested review" is a more common occurrence than "I toggled the Needs Review label because I got frustrated"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

2 participants