London | SDC-July-2025 | Franklin Kamela | Sprint 2 | jq exercises#98
Open
Fradoka wants to merge 10 commits intoCodeYourFuture:mainfrom
Open
London | SDC-July-2025 | Franklin Kamela | Sprint 2 | jq exercises#98Fradoka wants to merge 10 commits intoCodeYourFuture:mainfrom
Fradoka wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
LonMcGregor
reviewed
Aug 11, 2025
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi, I'm assuming you only want me to review what is in the jq directory - I think you may have accidentally committed other files as well.
Good work on the jq tasks - I only have a comment for task 2
jq/script-02.sh
Outdated
| # TODO: Write a command to output the address of the person, all on one line, with a comma between each line. | ||
| # Your output should be exactly the string "35 Fashion Street, London, E1 6PX", but should not contain any quote characters. | ||
| path="/Users/cyf/Documents/SDC/Module-Tools/jq/person.json" | ||
| jq -r '.address | "\(.[0]), \(.[1]), \(.[2])"' $path No newline at end of file |
There was a problem hiding this comment.
Can you think of a solution that would work if the address has more than 3 lines?
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions