London | SDC-MARC-2026| Jamal Laqdiem | Sprint 1| Number Systems#339
London | SDC-MARC-2026| Jamal Laqdiem | Sprint 1| Number Systems#339jamallaqdiem wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
jamallaqdiem
added
the
Needs Review
DaryaShirokova
added
Review in progress
DaryaShirokova
left a comment
DaryaShirokova
left a comment
There was a problem hiding this comment.
Great progress, just suggested to approach some things differently for practice
number-systems/README.md
Outdated
| 1000 = 8 | ||
| 0111 = 7 |
There was a problem hiding this comment.
While it is correct, the module asks to not translate to decimal unless specified explicitly. Maybe think of an alternative way to arrive to this conclusion?
There was a problem hiding this comment.
Thank you for taking time to reviewing. I will address the issue.
number-systems/README.md
Outdated
| 10101 = 21 | ||
| 01010 = 10 | ||
| 21+10 = 31 |
There was a problem hiding this comment.
Can you do binary arithmetic here and in other questions as well? Not saying it is wrong, but the goal here is to get used to doing operations in a different system, not translate everything to decimal.
There was a problem hiding this comment.
Thank you for taking time to reviewing. I will address the issue.
DaryaShirokova
added
Reviewed
jamallaqdiem
added
the
Needs Review
DaryaShirokova
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
Completing exercises about bit, decimal and hexaecimal.