Skip to content

ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 3 | Implement Shell Tools#247

Open
Rashaad-Ebrahim wants to merge 19 commits intoCodeYourFuture:mainfrom
Rashaad-Ebrahim:implement-shell-tools
Open

ZA | 25-SDC-Nov | Rashaad Ebrahim | Sprint 3 | Implement Shell Tools#247
Rashaad-Ebrahim wants to merge 19 commits intoCodeYourFuture:mainfrom
Rashaad-Ebrahim:implement-shell-tools

Conversation

@Rashaad-Ebrahim
Copy link

@Rashaad-Ebrahim Rashaad-Ebrahim commented Nov 24, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

My node implementations of the the Unix commands cat, ls and wc.

Questions

No questions at this time

@Rashaad-Ebrahim Rashaad-Ebrahim linked an issue Nov 24, 2025 that may be closed by this pull request
01 Implement shell tools (cat, ls, wc) in JavaScript with NodeJS Rashaad-Ebrahim/My-Coursework-Planner#6
Open
@Rashaad-Ebrahim Rashaad-Ebrahim added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 24, 2025
MattGoodwin0
MattGoodwin0 suggested changes Dec 21, 2025
View reviewed changes
Copy link

@MattGoodwin0 MattGoodwin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review cat, ls, and wc implementations against backlog requirements

It looks like you have a strong understanding of both cat and ls!

wc has a great understanding too but you may want to review to ensure it behaves as expcted

@MattGoodwin0 MattGoodwin0 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 21, 2025
@Rashaad-Ebrahim Rashaad-Ebrahim added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 22, 2025
MattGoodwin0
MattGoodwin0 approved these changes Dec 22, 2025
View reviewed changes
Copy link

@MattGoodwin0 MattGoodwin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@MattGoodwin0 MattGoodwin0 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 22, 2025
LonMcGregor
LonMcGregor reviewed Dec 23, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, accidentally did a 2nd review,didn't realise someone else had already checked this)

implement-shell-tools/ls/ls.js
Copy link

@LonMcGregor LonMcGregor Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean and concise solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

+1 more reviewer

@MattGoodwin0 MattGoodwin0 MattGoodwin0 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

01 Implement shell tools (cat, ls, wc) in JavaScript with NodeJS

3 participants

@Rashaad-Ebrahim @LonMcGregor @MattGoodwin0