Skip to content

London | 25-SDC-NOV | Tewodros Bekere | Sprint 1 | Shell Tools#203

Open
iteddy16 wants to merge 6 commits intoCodeYourFuture:mainfrom
iteddy16:Shell-Tools
Open

London | 25-SDC-NOV | Tewodros Bekere | Sprint 1 | Shell Tools#203
iteddy16 wants to merge 6 commits intoCodeYourFuture:mainfrom
iteddy16:Shell-Tools

Conversation

@iteddy16
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Answered all the questions in the individual-shell-tools folder for ls, cat, wc, grep, sed, awk.

@iteddy16 iteddy16 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

# The output should contain 11 lines.
# Line 3 should be "It contains many lines, and there are some things you may want to do with each of them.".
# Line 11 should be "We also should remember, when we go shopping, to get 4 items: oranges, cheese, bread, olives.".
sed 's/,/& /g' input.txt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to add extra spaces where there are already spaces following a comma. Can you fix that?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants