Skip to content

Glasgow | 26-ITP-Jan| Martin McLean | Sprint 2 | coursework#963

Open
mjm-git185 wants to merge 5 commits intoCodeYourFuture:mainfrom
mjm-git185:Coureswork_Sprint-2
Open

Glasgow | 26-ITP-Jan| Martin McLean | Sprint 2 | coursework#963
mjm-git185 wants to merge 5 commits intoCodeYourFuture:mainfrom
mjm-git185:Coureswork_Sprint-2

Conversation

@mjm-git185
Copy link

@mjm-git185 mjm-git185 commented Feb 13, 2026

Changelist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

my coursework

@github-actions

This comment has been minimized.

@mjm-git185 mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026
@github-actions

This comment has been minimized.

@mjm-git185 mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026
@mjm-git185 mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 13, 2026
@Edu-Vin Edu-Vin added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 13, 2026

// // =============> write the error message here
// /home/martinmclean158/Module-Structuring-and-Testing-Data/Sprint-2/1-key-errors/0.js:8
// let str = `${str[0].toUpperCase()}${str.slice(1)}`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error message is wrong. Try running it again

// // =============> write your new code here
function multiply(a, b) {
const result = a * b;
console.log(result);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is a console.log of the result outside the function, is there a need for the console.log in the function?

// =============> yes thay all give 3
// Explain why the output is the way it is
// =============> write your explanation here
// because the variable is a consrent
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your explanation.

It means if I add const num = 103; to your solution before getLastDigit(), will it return 3 for all the console logs?

function calculateBMI(weight, height) {
// return the BMI of someone based off their weight and height
} No newline at end of file
let bmi = weight/(height*height)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you used let instead of const?

// You will need to come up with an appropriate name for the function
// Use the MDN string documentation to help you find a solution
// This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
function SNAKE_CASE (mesasge){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the name of the function follow the appropriate naming convention? Does it explain what the function does?


// b) What is the value assigned to num when pad is called for the first time?
// =============> write your answer here
// "null"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since totalHours is the value used to call pad for the first time. Try doing a console.log to be sure it is null

@Edu-Vin Edu-Vin added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 13, 2026
@mjm-git185 mjm-git185 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026
@mjm-git185
Copy link
Author

i have made the changes needed

@mjm-git185 mjm-git185 requested a review from Edu-Vin February 14, 2026 12:19
@Edu-Vin
Copy link

Edu-Vin commented Feb 14, 2026

i have made the changes needed

I can't find the changes you made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants