Glasgow | Jan-26 | Elisabeth Matulian | Sprint 1 | Coursework by Elisabeth-Matulian · Pull Request #936 · CodeYourFuture/Module-Structuring-and-Testing-Data

Elisabeth-Matulian · 2026-02-07T15:41:08Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed key exercises
Completed mandatory errors
Completed mandatory interpret
Completed stretch explore

Theoreoluwa · 2026-02-14T00:11:35Z

Sprint-1/1-key-exercises/3-paths.js

-const dir = ;
-const ext = ;
+
+const dir = filePath.slice(0, filePath.lastIndexOf("/",lastSlashIndex - 1));


Can you take a look at the output this line gives you and check if it aligns exactly with the full dir path as indicated in the task?

I removed the second parameter from lastIndexOf and reused the existing lastSlashIndex variable

Theoreoluwa · 2026-02-14T00:19:40Z

Sprint-1/2-mandatory-errors/3.js

Yes, you updated the cardNumber variable, but you need to explain your reasoning behind it as indicated in the comments for the task.

My bad:)
I initially thought this reasoning should be done mentally rather than written in the code. Thanks for mention it

Theoreoluwa · 2026-02-14T00:21:26Z

Sprint-1/2-mandatory-errors/4.js

-const 12HourClockTime = "20:53";
-const 24hourClockTime = "08:53";
+const ClockTime12Hour = "20:53";
+const ClockTime24Hour = "08:53";


Very good variable naming convention. A bit of explanation with comments as to why you got an error and how you figured out the solution would help better practice.

Thanks. Comment added

Theoreoluwa · 2026-02-14T00:30:18Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+// d) This way, we find out how many full minutes the film lasts. 

 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// e) This variable stores information about the exact length of the film (hours:minutes:seconds). I would call it “hoursMinutesSeconds”


This part is really subjective, but if you could go with a better variable name based on the context provided from the existing variable names, that would be better.

I updated the name of the variable

Theoreoluwa · 2026-02-14T00:42:33Z

Sprint-1/4-stretch-explore/chrome.md

 What is the return value of `prompt`?
+Answer: undefined


You can recheck if the return type is actually what you say it is. If you input your name in the prompt, you should get the datatype for your name returned.

updated with the correct answer

Theoreoluwa

Kindly look into my comments and adjust them accordingly. Great job so far, keep going!

Theoreoluwa · 2026-02-14T01:13:00Z

Sprint-1/3-mandatory-interpret/1-percentage-change.js

 // Read the code and then answer the questions below

 // a) How many function calls are there in this file? Write down all the lines where a function call is made
+// a) Lines 4,5,10


You need to include a number of function calls in there after looking into each line properly.

answer added for the first question. I need to be more attentive%)

Thank you for checking my coursework and for your detailed feedback. I have updated it. Could you please take another look when you have a moment?

Theoreoluwa · 2026-02-15T00:03:22Z

Sprint-1/2-mandatory-errors/3.js

+// .slice() method works with String type, not with Number type. Therefore there will be an error
 // Then run the code and see what error it gives.
 // Consider: Why does it give this error? Is this what I predicted? If not, what's different?
 // Then try updating the expression last4Digits is assigned to, in order to get the correct value
+// the error is: "TypeError: cardNumber.slice is not a function" this matches my prediction. The error occurred because the method doen't work with Number type. I've changed cardNumber to a String when added quotes around the number. 


Now, you did the right thing by explaining your reasoning to debug the error. I would suggest applying a much cleaner way to convert the variable into a string without redeclaring it. You can look into that method using MDN docs.

Theoreoluwa · 2026-02-15T00:04:51Z

Sprint-1/2-mandatory-errors/4.js

+const ClockTime12Hour = "20:53";
+const ClockTime24Hour = "08:53";
+// variable names cannot start with a number in JavaScript syntax


Good comment. I would advise you use camelCase as your variable naming convention instead of PascalCase as that is more suitable for class names.

Theoreoluwa · 2026-02-15T00:07:10Z

Sprint-1/4-stretch-explore/chrome.md

 What effect does calling the `prompt` function have?
+Answer: A window pops up in the browser with a text input field
 What is the return value of `prompt`?
+Answer: the text that I entered in the input field that is stored in myName variable


Good explanation, but you need to learn to explicitly state the data type you are referring to when answering questions from the task.

Theoreoluwa

You've done very well, Elisabeth. Please, pay attention to my comments, as you will find them relevant as you carry on your journey. I will now mark your sprint PR as completed. Good luck and keep going!

Elisabeth-Matulian added 15 commits February 4, 2026 19:48

complete count.js exercise

de40d9d

complete initials.js

697d88c

completed_random.js

519042c

completed_0.js

4b1a9d9

completed_1.js

4d7676a

completed_2.js

c007b11

completed_paths.js

de87e88

completed_3.js

98976cf

update_path.js

2c37761

completed_4.js

984ab50

copmpleted_percentage-change.js

04ae366

completed_time-format.js

22e28cd

completed_3-to-pounds.js

6f38725

completed_chrome.md

2949452

completed_objects.md

3ad69fa

This comment has been minimized.

Sign in to view

Elisabeth-Matulian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

This comment has been minimized.

Sign in to view

Elisabeth-Matulian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

unnecessary_files_removed

dcaad30

Elisabeth-Matulian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026

Theoreoluwa added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 13, 2026

Theoreoluwa reviewed Feb 14, 2026

View reviewed changes

Theoreoluwa suggested changes Feb 14, 2026

View reviewed changes

Theoreoluwa reviewed Feb 14, 2026

View reviewed changes

Theoreoluwa suggested changes Feb 14, 2026

View reviewed changes

Elisabeth-Matulian added 6 commits February 14, 2026 16:13

fix: correct dir path

f66258c

add reasoning comments

8962e17

comment_added

e88aa97

fixed: correct prompt return

88000ae

fix: count all function calls including methods (5 total)

4013faf

updated_2-time-format

6613221

Elisabeth-Matulian added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 14, 2026

Theoreoluwa reviewed Feb 15, 2026

View reviewed changes

Theoreoluwa added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Feb 15, 2026

Theoreoluwa reviewed Feb 15, 2026

View reviewed changes

Uh oh!

Conversation

Elisabeth-Matulian commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Elisabeth-Matulian commented Feb 7, 2026 •

edited

Loading

Theoreoluwa Feb 14, 2026 •

edited

Loading