Skip to content

Cape Town | 2026-ITP-Jan | Isaac Abodunrin | Sprint 1 | Coursework Exercises#932

Open
bytesandroses wants to merge 19 commits intoCodeYourFuture:mainfrom
bytesandroses:coursework/sprint-1
Open

Cape Town | 2026-ITP-Jan | Isaac Abodunrin | Sprint 1 | Coursework Exercises#932
bytesandroses wants to merge 19 commits intoCodeYourFuture:mainfrom
bytesandroses:coursework/sprint-1

Conversation

@bytesandroses
Copy link
Member

@bytesandroses bytesandroses commented Feb 6, 2026

Self checklist:

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed the following exercises:

  • Key Exercises
  • Mandatory Errors
  • Mandatory Interpret

@bytesandroses bytesandroses added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@bytesandroses bytesandroses mentioned this pull request Feb 6, 2026
Open
cjyuan
cjyuan reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great. I just have a few questions.

Sprint-1/1-key-exercises/1-count.js Outdated

// Line 1 is a variable declaration, creating the count variable with an initial value of 0
// Describe what line 3 is doing, in particular focus on what = is doing
// Answer: Line 3 reassigns the value of count by increasing it by 1. It therefore increases the value of count from 0 to 1
Copy link
Contributor

@cjyuan cjyuan Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.

Can you find out what one-word programming term describes the operation on line 3?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 13, 2026
@bytesandroses
Copy link
Member Author

bytesandroses commented Feb 15, 2026

@cjyuan Thank you so much for the feedback CJ. I've gone ahead and implemented the suggestions made.

Changes:

  1. 1-key-exercises/1-count.js
    More clearly communicated the incrimination on Line 3

  2. 3-mandatory-interpret/2-time-format.js
    Corrected the number of function calls to 1

  3. 3-mandatory-interpret/3-to-pounds.js
    Removed unnecessary dead code .padEnd(2, "0")

@bytesandroses bytesandroses added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 15, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 15, 2026 •
edited
Loading

  • incrimination is not the right term. Well, you got it right in the code.

You should try responding directly in the inline comment. Doing so makes tracking conversation easier.

Changes look good. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bytesandroses @cjyuan