London | 26-ITP-Jan | Abdul Moiz | Sprint 3 | implement-and-rewrite by A-Moiz · Pull Request #915 · CodeYourFuture/Module-Structuring-and-Testing-Data

A-Moiz · 2026-01-27T18:52:39Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all the exercises in implement-and-rewrite directory

Questions

N/A

…proper-fraction.js

cjyuan · 2026-02-11T06:27:47Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  if (denominator === 0) {
+    return false;
+  } else if (Math.abs(numerator) < Math.abs(denominator)) {
+    return true;
+  } else {
+    return false;
+  }


This works.
Optional challenge: Simplify the code.

cjyuan · 2026-02-11T06:34:55Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 function getCardValue(card) {
-  // TODO: Implement this function
+  const rank = card.slice(0, card.length - 1);


The requirements has changed a bit.
To ensure card is valid, you should also check if the last character is a valid suit character.

cjyuan · 2026-02-11T06:36:02Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  } else if (Number(rank) >= 2 && Number(rank) < 10) {
+    return Number(rank);


In JavaScript, strings that represent valid numeric literals in the language can be safely
converted to equivalent numbers or parsed into a valid integers.
Do you want to recognize these string values as valid ranks? If not, you will need to enforce stricter check.

To find out what these strings are, you can ask AI

What kinds of string values would make Number(rank) evaluate to 2 in JS?

I added an if statement beforehand to check typeof for the variable. If it fails it will throw an error.

cjyuan · 2026-02-11T06:39:33Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test(`should return true for proper fraction with positive numerator and denominator`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+});
+
+test(`should return false for improper fraction with positive numerator and denominator`, () => {
+  expect(isProperFraction(3, 2)).toEqual(false);
+});
+


What about negative numbers and different combinations of positive/negative/zero?

Think also what edge case to check?

Added extra tests for negative numerators/denominators and all are passing.

cjyuan · 2026-02-11T06:41:45Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  } else {
+    return "Invalid card rank";
+  }


The new requirement is:

// When the card string is invalid (not following the above format), the function should
// throw an error.

Throwing an error is not the same as returning an error message.
Could you look up "How to throw an error in JS" and update your code accordingly?

Modified function and test case to throw error.

cjyuan · 2026-02-11T06:44:16Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+  expect(getCardValue("11♥")).toEqual("Invalid card rank");
+  expect(getCardValue("Z♦")).toEqual("Invalid card rank");
+});
+


Could also include invalid cases that involves invalid suit character.

To test if a function can throw an error as expected, we could use .toThrow(). You can find out more about how to use .toThrow() here: https://jestjs.io/docs/expect#tothrowerror (Note: Pay close attention to the syntax of the example)

cjyuan · 2026-02-14T14:57:12Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js


 function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+  return Math.abs(numerator) < Math.abs(denominator) ? true : false;


When an expression evaluates to a Boolean value, we can also just return the value of the expression:
return Math.abs(numerator) < Math.abs(denominator);

cjyuan · 2026-02-14T15:05:21Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  const rankNum = Number(rank);
+  if (!Number.isNaN(rankNum) && rankNum >= 2 && rankNum < 10) {
+    return rankNum;
+  }


I added an if statement beforehand to check typeof for the variable. If it fails it will throw an error.

I don't see any statement involving typeof.

Currently, a card value like ""0x02♠" or "3.1416♠" can still pass the check on line 37.

Apologies, I got it mixed up with a different task. It is resolved now.

cjyuan · 2026-02-14T15:07:21Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test(`should return false for negative numerator`, () => {
+  expect(isProperFraction(-5, 2)).toEqual(false);
+});
+
+test(`should return false for negative numerator`, () => {
+  expect(isProperFraction(-5, 2)).toEqual(false);
+});


Same test sample.

cjyuan

Changes look good. Well done.

cjyuan · 2026-02-14T16:39:24Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+    !Number.isNaN(rankNum) &&
+    Number.isInteger(rankNum) &&
+    rankNum >= 2 &&
+    rankNum < 10 &&
+    rank === rankNum.toString()


This works, but an approach similar to that at line 29 is probably cleaner.

A-Moiz added 7 commits January 27, 2026 16:23

Completed 1-get-angle-type.js exercise

5f845d0

Completed 2-is-proper-fraction.js exercise

2b5822f

Completed 3-get-card-value.js exercise

a08e5c7

Merged branch main into coursework/sprint-3-implement-and-rewrite

05ac5d6

Completed 1-get-angle-type.test.js exercise

b7ff208

Completed 2-is-proper-fraction.test.js and modified function in 2-is-…

2fdc1ca

…proper-fraction.js

Completed 3-get-card-value.test.js

d6ce110

A-Moiz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 27, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 27, 2026

This comment has been minimized.

Sign in to view

Removed package-lock.json from PR tracking

1ba0eff

A-Moiz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 27, 2026

A-Moiz mentioned this pull request Jan 31, 2026

ITP-JAN-26 | Structuring and testing data | Abdul Moiz A-Moiz/My-Coursework-Planner#54

Open

cjyuan reviewed Feb 11, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 11, 2026

Made changes based on comments received.

7d4b528

A-Moiz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 14, 2026

cjyuan reviewed Feb 14, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 14, 2026

A-Moiz added 2 commits February 14, 2026 15:44

Made changes based on comments

ac777a7

Made changes based on comments on github.

03452aa

A-Moiz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 14, 2026

cjyuan reviewed Feb 14, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 14, 2026

		} else if (Number(rank) >= 2 && Number(rank) < 10) {
		return Number(rank);

Uh oh!

Conversation

A-Moiz commented Jan 27, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants