London | 26-ITP-May | Rhoda Ajiroba | Sprint 3 | Structuring and Testing Data - #1563
Open
codebyra wants to merge 5 commits into
Open
London | 26-ITP-May | Rhoda Ajiroba | Sprint 3 | Structuring and Testing Data#1563codebyra wants to merge 5 commits into
codebyra wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
codebyra
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
codebyra
added
the
Needs Review
Author
|
@LonMcGregor Please review this too |
cjyuan
reviewed
Jul 27, 2026
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
| return numerator >= 0 && denominator > 0 && numerator < denominator; |
Contributor
There was a problem hiding this comment.
What authoritative source do you base your definition of a proper fraction on?
cjyuan
added
Reviewed
Contributor
|
You also missed updating |
codebyra
added
the
Needs Review
Author
|
@cjyuan Please review the changes |
cjyuan
reviewed
Aug 6, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you also address this comment: #1563 (comment)
| assertEquals(isProperFraction(5, 2), false); | ||
| assertEquals(isProperFraction(-1, 2), false); | ||
| assertEquals(isProperFraction(1, 0), false); | ||
| assertEquals(isProperFraction(0, 5), false); No newline at end of file |
Contributor
There was a problem hiding this comment.
According to which authoritative definition -1/2 and 0/5 are not considered proper fractions?
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Sprint 3 mandatory exercises for the Structuring and Testing Data module.
Implemented and tested the required Sprint 3 exercises, including rewriting tests with Jest, practice TDD, and dead code removal.