generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 416
London | 26-ITP-Jan | Mohsen Zamani | sprint 2 | Form Controls #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohsenzamanist
wants to merge
5
commits into
CodeYourFuture:main
Choose a base branch
from
mohsenzamanist:form-controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
00de676
Add max-width property to img
mohsenzamanist 8d62c98
Change the wireframe
mohsenzamanist a0f4237
Create form to collected user's data of T-shirts
mohsenzamanist 8c7aef3
Revert accidental changes to fiels in Wireframe folder
mohsenzamanist 52a6ee9
Name field should be at least two chars long
mohsenzamanist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,13 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta | ||
| name="description" | ||
| content="A form to collect user's data on T-shirt" | ||
| /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| </head> | ||
| <body> | ||
|
|
@@ -13,15 +16,72 @@ <h1>Product Pick</h1> | |
| </header> | ||
| <main> | ||
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <!-- customer's validated name - required --> | ||
| <div> | ||
| <label for="name">Name: </label> | ||
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| required | ||
| placeholder="Mohsen Zamani" | ||
| minlength="2" | ||
| /> | ||
| </div> | ||
| <br /> | ||
| <!-- customer's email address in proper format - required --> | ||
| <div> | ||
| <label for="email">Email: </label> | ||
| <input | ||
| type="email" | ||
| id="email" | ||
| name="email" | ||
| required | ||
| placeholder="[email protected]" | ||
| /> | ||
| </div> | ||
| <br /> | ||
| <!-- colour of T-shirt, 3 options available, only one should be picked - required --> | ||
| <div> | ||
| <label for="colour">Colour: </label> | ||
| <select name="colour" id="colour" required> | ||
| <option value="red">Red</option> | ||
| <option value="blue">Blue</option> | ||
| <option value="green" selected>Green</option> | ||
| </select> | ||
| </div> | ||
| <br /> | ||
| <!-- size XS, S, M, L, XL, XXL - required --> | ||
| <div> | ||
| Size: | ||
|
|
||
| <input type="radio" name="size" id="xs" value="sx" required /> | ||
| <label for="xs">XS</label> | ||
| | ||
| <input type="radio" name="size" id="s" value="s" /> | ||
| <label for="s">S</label> | ||
| | ||
| <input type="radio" name="size" id="m" value="m" /> | ||
| <label for="m">M</label> | ||
| | ||
| <input type="radio" name="size" id="l" value="l" /> | ||
| <label for="l">L</label> | ||
| | ||
| <input type="radio" name="size" id="xl" value="xl" /> | ||
| <label for="xl">XL</label> | ||
| | ||
| <input type="radio" name="size" id="xxl" value="xxl" /> | ||
| <label for="xxl">XXL</label> | ||
| </div> | ||
| <br /> | ||
| <button type="submit">Submit</button> <button type="reset"> | ||
| Reset | ||
| </button> | ||
| </form> | ||
| </main> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <h2>By MOHSEN ZAMANI</h2> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specification in the readme has some specific rules about what a valid name should be. Can you find where that is and see if your solution meets it?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point. I missed this line:
but resolved it.