Skip to content

Conversation

@alizada-dev
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Created an HTML form to collect the name and email address of the customers along with their size and color preferences. The form is validated with built-in HTML validation.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 9980528
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/696cc429e8b7ab0008960893
😎 Deploy Preview https://deploy-preview-925--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@alizada-dev alizada-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 6, 2026
@jenny-alexander jenny-alexander self-requested a review January 15, 2026 04:48
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 15, 2026
@alizada-dev
Copy link
Author

Hi @jenny-alexander, can you please review this PR? As it has been under review for progress since yesterday. Thank you!

@alizada-dev
Copy link
Author

If all the requirements are met, can you please change the review to 'complete'?

@jenny-alexander
Copy link

Hi @jenny-alexander, can you please review this PR? As it has been under review for progress since yesterday. Thank you!

I appreciate you wanting to move quickly on this! Just so you know, I typically try to review PRs within 24-48 hours after assigning them to myself.

Copy link

@jenny-alexander jenny-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alizada-dev - nice work with the form control exercise 👍 I can see that you have a good understanding of HTML form basics!

  • Please check the accessibility rating of your form. Currently it is '89' in Lighthouse.
Image
  • I left a few comments for you to review in order to improve code quality and the 'look' of the form.

@jenny-alexander jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 16, 2026
@alizada-dev alizada-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 18, 2026
@alizada-dev
Copy link
Author

Dear @jenny-alexander, thank you so much for dedicating time to reviewing my PR. I actually learned new concepts when I implemented your suggested changes.

@jenny-alexander
Copy link

Thanks for making those changes - the form looks great! 👏

@jenny-alexander jenny-alexander added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants