Skip to content

Cape Town | May-ITP-2026 | Enice Mutanda | Sprint 1 | Form Controls#1446

Open
Enice-Codes wants to merge 1 commit into
CodeYourFuture:mainfrom
Enice-Codes:form-controls
Open

Cape Town | May-ITP-2026 | Enice Mutanda | Sprint 1 | Form Controls#1446
Enice-Codes wants to merge 1 commit into
CodeYourFuture:mainfrom
Enice-Codes:form-controls

Conversation

@Enice-Codes

@Enice-Codes Enice-Codes commented Jun 12, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I used Html to create a form using provided information. I added other details such as phone number and reset button to make the form look professional. I used CSS to style the form to make it attractive and simple . tested the changes and was satisfied with the results.

I had git issues with my work so i had to delete my old work and fork it again
updated Html. This is a new PR request as I had to redo my work in order to resolve the merge conflicts that I was struggling to fix in my old repo. This is now a new repository that I cloned.

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1595c53
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2c37649152fc0008e0b953
😎 Deploy Preview https://deploy-preview-1446--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (🟢 up 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes changed the title Cape Town|May-ITP-2026|Enice Mutanda| Sprint1|Form Controls Cape Town | May-ITP-2026 | Enice Mutanda | Sprint 1 | Form Controls Jun 12, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 12, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Since this PR is a continuation of the previously reviewed PR (#1291), it would be helpful to mention that in the PR description. You could also briefly explain why a new PR was created and invite the reviewer from the previous PR to continue the review here. (Could you include such information in the PR description?)

As the deadline for submitting Step 1 evidence is today, I will continue reviewing this PR on behalf of @Luro91.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 12, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 12, 2026
@cjyuan

cjyuan commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Sorry that I wasn't clear enough in my previous comment. What I intended to say was,

You should keep the changelist content from your previous PR in this PR, as it explains the purpose and scope of the changes. The reason for opening a new PR can then be added as a separate note to provide context about the PR's history and why it was recreated.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 12, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 12, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 12, 2026
@cjyuan

cjyuan commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants