Skip to content

London | ITP-May-2026 | Carolina Villa | Sprint 2 | Wireframe Task#1443

Open
caro-vh wants to merge 21 commits into
CodeYourFuture:mainfrom
caro-vh:feature/wireframe
Open

London | ITP-May-2026 | Carolina Villa | Sprint 2 | Wireframe Task#1443
caro-vh wants to merge 21 commits into
CodeYourFuture:mainfrom
caro-vh:feature/wireframe

Conversation

@caro-vh

@caro-vh caro-vh commented Jun 11, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Used the provided wireframe and resources to write a new webpage that explains the purpose of README files, wireframes and what a brnach is.

Questions

No questions

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c45cc6c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2b0226381ff30008c3c8b1
😎 Deploy Preview https://deploy-preview-1443--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@caro-vh caro-vh added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jun 11, 2026
@cjyuan cjyuan removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jun 11, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error-free and well formatted. Page layout matches the wireframe well.

Can you assign different URLs to the "Read more" links to meet one of the requirements:

The articles section contains three distinct articles, each with its own unique image, title, summary, and link.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jun 11, 2026
@cjyuan

cjyuan commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

On separate notes,

  1. Can you update the PR description so that the "Changelist" header appear as a level-2 header:

Changelist

instead of just bolded text like this?

## Changelist

  1. Please note that in CYF course, the "Complete" label is to be added by a mentor.

@caro-vh caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026
@caro-vh

caro-vh commented Jun 11, 2026

Copy link
Copy Markdown
Author

Thanks, I have now fixed it.

@cjyuan

cjyuan commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

What about the links mentioned in this comment: #1443 (review) ?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026
@caro-vh caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026
@caro-vh

caro-vh commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hi, links added.

@cjyuan

cjyuan commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

All good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants