Skip to content

London | 26-ITP- Sept | Chandramani Gaire | Sprint 1 | Forms Controls #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaireprakash20-ops wants to merge 17 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP- Sept | Chandramani Gaire | Sprint 1 | Forms Controls #1507

Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c1b5342
Fixed error in code.
gaireprakash20-ops Sep 12, 2026
06f259f
add submit and reset button
gaireprakash20-ops Sep 12, 2026
26ee31c
adding the reset and put bracket on color
gaireprakash20-ops Sep 12, 2026
e5cb8dd
adding br space out the page
gaireprakash20-ops Sep 12, 2026
3c0daf7
space in name change
gaireprakash20-ops Sep 14, 2026
0e8d387
div tag change
gaireprakash20-ops Sep 14, 2026
8adacf3
change email
gaireprakash20-ops Sep 14, 2026
919333d
add fieldset
gaireprakash20-ops Sep 14, 2026
69c63c1
change the name of color and size
gaireprakash20-ops Sep 14, 2026
54cb7e7
change for on label of size
gaireprakash20-ops Sep 14, 2026
09f4a5f
change the size value in uppercase
gaireprakash20-ops Sep 14, 2026
194abd4
final submit
gaireprakash20-ops Sep 15, 2026
3bc4ca6
final check
gaireprakash20-ops Sep 15, 2026
c1a0239
formate change
gaireprakash20-ops Sep 16, 2026
fb4ab7b
final changes for formate
gaireprakash20-ops Sep 16, 2026
07f73f0
line deleted
gaireprakash20-ops Sep 16, 2026
91e0c1a
i only change the blank line
gaireprakash20-ops Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 46 additions & 6 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,59 @@
</head>
<body>
<header>
<h1>Product Pick</h1>
<h1>Pick product</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->

<!-- 1. What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.-->
<div>
<label for="name">Name</label>
<input type="text" id="name" placeholder="Chandrmani Gaire" pattern=".*\S.*\S." required>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare this pattern with the one in the README character by character. The last part is different. What does a . on its own match, and how many characters does it require after the second non-space one?

@gaireprakash20-ops gaireprakash20-ops Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type name=.\S.\S.* here

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. A is rejected and AB goes through now.

</div>
<br>
<div>
<label for="email">Email</label>
<input type="email" placeholder="chandramani@gmail.com" id="email" required>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two selects have a name attribute but the name and email inputs don't. What does name do when a form is submitted? Try submitting and look at the address bar.

@gaireprakash20-ops gaireprakash20-ops Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name="email"

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

</div>
<br>
<div>
<!--What colour should this T-shirt be? I must provide 3 options. How will I ensure they do not choose other colours? -->
<label for="coloroption">Color option</label>
<select id="coloroption" name="Color">

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This select has no required, and because the first option is a real colour it's already "chosen" when the page loads. What would you add so the customer has to make a choice? Same for the size select on line 42. The MDN form validation page from the prep covers this.

@gaireprakash20-ops gaireprakash20-ops Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put

on this section

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both dropdowns fixed. Good.

<option value="grey" >Grey</option>
<option value="black">Black</option>
<option value="red"> Red</option>
</select>
</div>
<br>
<div>

<!--What size does the customer want? I must provide the following 6 options: XS, S, M, L, XL, XXL -->
<label for="size">Size</label>
<select name="differentsize" id="size">
<option value="XS" >XS</option>
<option value="S" >S</option>
<option value="M" >M</option>
<option value="L" >L</option>
<option value="XL" >XL</option>
<option value="XXL" >XXL</option>
</select>
</div>
<br>
<div>
<input id="submit" type="submit">
</div>
<br>
</div>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which <div> is this closing? Count the opening and closing divs above it.

@gaireprakash20-ops gaireprakash20-ops Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear the

like this

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, validator is clean.

<div>
<input id="reset" type="reset">
</div>
</form>
</main>
<footer>
<!-- change to your name-->

@abdishakoor-dev abdishakoor-dev Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for this comment line, it can be removed.

<p>By HOMEWORK SOLUTION</p>
<p> By Chandramani Gaire</p>

@abdishakoor-dev abdishakoor-dev Sep 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra spaces before "By" and between your first and last name, and the starter comment on line 63 can go now.

@gaireprakash20-ops gaireprakash20-ops Sep 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the space

@abdishakoor-dev abdishakoor-dev Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces fixed. The starter comment on line 62 is still there, see the main comment.

</footer>
</body>
</html>
Loading