Skip to content

Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Alarmclock App #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TTiamiyu wants to merge 3 commits into
base: main
Choose a base branch
from
+43 −1
Open

Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Alarmclock App #1321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b59497e
Implement setAlarm function to parse input value and handle invalid o…
TTiamiyu Jul 27, 2026
c1008ba
Add timer clearing logic to setAlarm function for repeated button clicks
TTiamiyu Jul 27, 2026
d0e8ded
Refactor setAlarm function to improve countdown timer logic and ensur…
TTiamiyu Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,46 @@
function setAlarm() {}
let timerInterval = null;

function setAlarm() {
const inputEl = document.getElementById("alarmSet");
const timeRemainingEl = document.getElementById("timeRemaining");

let totalSeconds = parseInt(inputEl.value, 10);

// If input is invalid or empty, default to 0
if (isNaN(totalSeconds) || totalSeconds < 0) {
totalSeconds = 0;

@Luro91 Luro91 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if the expected user behaviour for invalid inputs is to set the seconds to 0. What else could you do instead?

}
// Clear any existing timer if the button is clicked again
if (timerInterval) {
clearInterval(timerInterval);
}
// Function to render the formatted time (MM:SS) to the DOM
function updateDisplay() {

@Luro91 Luro91 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job putting the code for formatting and setting the countdown into an own function. This makes it reusable and easier to change the formtting if needed

const minutes = Math.floor(totalSeconds / 60);
const seconds = totalSeconds % 60;

const formattedMinutes = String(minutes).padStart(2, "0");
const formattedSeconds = String(seconds).padStart(2, "0");

timeRemainingEl.innerText = `Time Remaining: ${formattedMinutes}:${formattedSeconds}`;
}
// 1. Immediately set heading on button click
updateDisplay();

// 2. Start the countdown timer
timerInterval = setInterval(() => {
totalSeconds -= 1;

if (totalSeconds >= 0) {
updateDisplay();
}

if (totalSeconds === 0) {
playAlarm();
clearInterval(timerInterval);
}
}, 1000);
}

// DO NOT EDIT BELOW HERE

Expand Down
Loading