London | 26-ITP-May | Zadri Abdule | Sprint 3 | alarm-clock app - #1319
Open
Zadri415 wants to merge 2 commits into
Open
London | 26-ITP-May | Zadri Abdule | Sprint 3 | alarm-clock app#1319Zadri415 wants to merge 2 commits into
Zadri415 wants to merge 2 commits into
Conversation
Zadri415
added
Needs Review
Luro91
reviewed
Jul 30, 2026
| let seconds = parseInt(input.value, 10); | ||
| if (!Number.isFinite(seconds) || seconds < 0) seconds = 0; | ||
|
|
||
| function formatMMSS(s) { |
There was a problem hiding this comment.
Good job putting the code for formatting into an own function. This makes it reusable and easier to change the formtting if needed
|
|
||
| heading.innerText = formatMMSS(seconds); | ||
|
|
||
| if (window._alarmIntervalId) { |
There was a problem hiding this comment.
Why are you adding _alarmIntervalId to the window object?
| const heading = document.getElementById("timeRemaining"); | ||
|
|
||
| let seconds = parseInt(input.value, 10); | ||
| if (!Number.isFinite(seconds) || seconds < 0) seconds = 0; |
There was a problem hiding this comment.
I am not sure if the expected user behaviour for invalid inputs is to set the seconds to 0. What else could you do instead?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed sprint 3 alarm - clock app task.