London | 26-ITP-May | Eyob Zeray | Sprint 3 | alarmclock - #1316
Open
eyob-tech wants to merge 1 commit into
Open
Conversation
eyob-tech
added
🏕 Priority Mandatory
Luro91
reviewed
Jul 30, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
The title of the webpage should say Alarm clock app. It says Title here at the moment
Comment on lines
+7
to
+13
| function updateDisplay() { | ||
| const minutes = Math.floor(secondsRemaining / 60); | ||
| const seconds = secondsRemaining % 60; | ||
| const paddedMinutes = String(minutes).padStart(2, "0"); | ||
| const paddedSeconds = String(seconds).padStart(2, "0"); | ||
| heading.innerText = `Time Remaining: ${paddedMinutes}:${paddedSeconds}`; | ||
| } |
There was a problem hiding this comment.
Good job putting the code for formatting into an own function. This makes it reusable and easier to change the formatting if needed
| const input = document.getElementById("alarmSet"); | ||
| const heading = document.getElementById("timeRemaining"); | ||
|
|
||
| let secondsRemaining = Number(input.value); |
There was a problem hiding this comment.
What happens if the number is 0 or negative?
| @@ -1,4 +1,29 @@ | |||
| function setAlarm() {} | |||
| function setAlarm() { | |||
There was a problem hiding this comment.
What happens when a user clicks the set alarm button multiple times?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented setAlarm() in alarmclock.js so the app counts down from a
user-entered number of seconds, displays the remaining time in
#timeRemaining as MM:SS, and calls playAlarm() once it reaches zero.
Along the way, fixed a syntax error (missing backticks around template
literals) that was causing the whole script to fail to load and all 5 tests
to fail. All 5 tests in alarmclock.test.js now pass.