Glasgow | Sheetal Kharab | Module-Complexity | Sprint 1 | Analyse and refactor#32
Open
sheetalkharab wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Glasgow | Sheetal Kharab | Module-Complexity | Sprint 1 | Analyse and refactor#32sheetalkharab wants to merge 5 commits intoCodeYourFuture:mainfrom
sheetalkharab wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
sheetalkharab
added
the
Needs Review
cjyuan
reviewed
Jan 22, 2026
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity:O(2n) originall have this as using 2 separate loops |
There was a problem hiding this comment.
O(n) is the same as O(2n). We ignore the constant multiplier in big-O notation.
Author
There was a problem hiding this comment.
Thank you for the clarification.
I’ve updated the time complexity to O(n), since constant multipliers are ignored in Big-O notation.
| * Time Complexity: | ||
| * Space Complexity: | ||
| * Optimal Time Complexity: | ||
| * Time Complexity:O(n+m) it build set and loop through arrays once |
There was a problem hiding this comment.
What's the complexity of Array.include()?
.filter() suggests a "loop", and inside the loop .includes() is called repeatedly.
Author
There was a problem hiding this comment.
@cjyuan Thank you for the clarification.
The previous implementation using .includes() would have been O(n × m).
After refactoring to use a Set, the time complexity is now O(n + m), and space complexity is O(m).
| * Optimal Time Complexity: | ||
| * Time Complexity:O(n+m) it build set and loop through arrays once | ||
| * Space Complexity: store second array in set | ||
| * Optimal Time Complexity:O(m+n) |
cjyuan
added
Reviewed
sheetalkharab
added
the
Needs Review
|
Code is good. Thanks for all responses. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
refactor code
Questions
No