-
-
Notifications
You must be signed in to change notification settings - Fork 28
London | 25-SDC-July | Eyuel Abraham | Sprint 2 | Improve with caches #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c5aed12
1be1ae2
7cd1fdb
556ea34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,10 @@ | ||
| _memo = {} | ||
|
|
||
| def fibonacci(n): | ||
| if n in _memo: | ||
| return _memo[n] | ||
| if n <= 1: | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| _memo[n] = fibonacci(n - 1) + fibonacci(n - 2) | ||
| return _memo[n] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,45 @@ | ||
| from typing import List | ||
|
|
||
| from typing import List, Dict, Tuple | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| coins = [200, 100, 50, 20, 10, 5, 2, 1] | ||
| memo: Dict[Tuple[int, int], int] = {} | ||
| return ways_to_make_change_helper(total, coins, memo) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| def ways_to_make_change_helper(total: int, coins: List[int], memo: Dict[Tuple[int, int], int]) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| Uses memoization to cache results for (total, coin_index). | ||
|
|
||
| The memoization key uses len(coins) to represent the current position. | ||
| len(coins) encodes the current position, since coins is always a suffix | ||
| of the original list. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| return 0 | ||
| if total == 0: | ||
| return 1 | ||
| if total < 0 or not coins: | ||
| return 0 | ||
|
|
||
| key = (total, len(coins)) | ||
| if key in memo: | ||
| return memo[key] | ||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
| count_of_coin = 1 | ||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
| if total_from_coins == total: | ||
| remainder = total - coin * count_of_coin | ||
| if remainder == 0: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| ways += ways_to_make_change_helper(remainder, coins[coin_index + 1:], memo) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Overall good approach with memoization, but I have one tiny request here:
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In Python, doing list[x:y] creates a new list containing the elements from index x to y-1. This requires allocating additional memory proportional to the slice length. we can use a module called intertools (itertools.islice), which returns a lazy iterator over that range instead of creating a new list to avoid excess memory allocation. |
||
| count_of_coin += 1 | ||
|
|
||
| memo[key] = ways | ||
| return ways | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably document what the cache key here is in the docstring - it's not obvious what the two values in the tuple are (and it took me a minute to work out why
len(coins)was a valid thing to include in the cache key at all).