Skip to content

[client-v2,jdbc-v2] Fix Writing Date/Time values #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chernser wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[client-v2,jdbc-v2] Fix Writing Date/Time values #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6966916
Added date time converters.
chernser Dec 17, 2025
0a37a12
Merge branch 'main' into 12/16/jdbc_datetime_conversion_2
chernser Jan 12, 2026
25231f6
Added small tests - date time conversion examples
chernser Jan 21, 2026
b70da39
Merge branch 'main' into 12/16/jdbc_datetime_conversion_2
chernser Feb 3, 2026
c8a2752
Merge branch 'main' into 12/16/jdbc_datetime_conversion_2
chernser Feb 9, 2026
3379f9f
Updated converting of LocalDate and LocalTime to Date and Time.
chernser Feb 10, 2026
b09a59e
made proper covnersion from time to Duration
chernser Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
327 changes: 327 additions & 0 deletions client-v2/src/main/java/com/clickhouse/client/api/DataTypeUtils.java
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 22 additions & 3 deletions ...main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.clickhouse.client.api.ClientConfigProperties;
import com.clickhouse.client.api.ClientException;
import com.clickhouse.client.api.DataTypeUtils;
import com.clickhouse.client.api.data_formats.ClickHouseBinaryFormatReader;
import com.clickhouse.client.api.internal.DataTypeConverter;
import com.clickhouse.client.api.internal.MapUtils;
Expand Down Expand Up @@ -680,13 +681,31 @@ public ZonedDateTime getZonedDateTime(int index) {

@Override
public Duration getDuration(int index) {
TemporalAmount temporalAmount = getTemporalAmount(index);
return temporalAmount == null ? null : Duration.from(temporalAmount);
Object value = readValue(index);
if (value == null) {
return null;
}
if (value instanceof LocalDateTime) {
return DataTypeUtils.localDateTimeToDuration((LocalDateTime) value);
} else if (value instanceof TemporalAmount) {
return Duration.from((TemporalAmount)value);
}
throw new ClientException("Column at index " + index + " cannot be converted to Duration");
}

@Override
public TemporalAmount getTemporalAmount(int index) {
return readValue(index);
Object value = readValue(index);
if (value == null) {
return null;
}
if (value instanceof LocalDateTime) {
return DataTypeUtils.localDateTimeToDuration((LocalDateTime) value);
} else if (value instanceof TemporalAmount) {
return (TemporalAmount) value;
}

throw new ClientException("Column at index " + index + " cannot be converted to TemporalAmount");
}

@Override
Expand Down
25 changes: 22 additions & 3 deletions client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/MapBackedRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.clickhouse.client.api.data_formats.internal;

import com.clickhouse.client.api.ClientException;
import com.clickhouse.client.api.DataTypeUtils;
import com.clickhouse.client.api.internal.DataTypeConverter;
import com.clickhouse.client.api.metadata.TableSchema;
import com.clickhouse.client.api.query.GenericRecord;
Expand Down Expand Up @@ -173,13 +174,31 @@ public ZonedDateTime getZonedDateTime(String colName) {

@Override
public Duration getDuration(String colName) {
TemporalAmount temporalAmount = readValue(colName);
return temporalAmount == null ? null : Duration.from(temporalAmount);
Object value = readValue(colName);
if (value == null) {
return null;
}
if (value instanceof LocalDateTime) {
return DataTypeUtils.localDateTimeToDuration((LocalDateTime) value);
} else if (value instanceof TemporalAmount) {
return Duration.from((TemporalAmount)value);
}
throw new ClientException("Column " + colName + " cannot be converted to Duration");
}

@Override
public TemporalAmount getTemporalAmount(String colName) {
return readValue(colName);
Object value = readValue(colName);
if (value == null) {
return null;
}
if (value instanceof LocalDateTime) {
return DataTypeUtils.localDateTimeToDuration((LocalDateTime) value);
} else if (value instanceof TemporalAmount) {
return (TemporalAmount) value;
}

throw new ClientException("Column " + colName + " cannot be converted to TemporalAmount");
}

@Override
Expand Down
Loading
Loading