removed third-party-libraries folder as not used #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the third-party-libraries folder and its internal repackaged dependencies, migrating to upstream artifacts instead. The change simplifies the build by eliminating custom JPMS-compatible wrappers that are no longer necessary.
- Removes unused dependencies (io.grpc, org.congocc) and redundant repackaged libraries
- Switches to upstream
org.roaringbitmap:RoaringBitmap(version 1.0.6) and updates JPMS module references - Cleans up POM files and GitHub workflow for third-party library publishing
Reviewed changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| third-party-libraries/* | Entire directory removed including pom.xml, source files, and all module subdirectories |
| .github/workflows/third_party_libs.yml | Removes CI workflow for building/publishing repackaged libraries |
| pom.xml | Updates roaring-bitmap version to 1.0.6, removes dependency management entries for repackaged libraries |
| clickhouse-data/pom.xml | Replaces repackaged org.roaringbitmap dependency with upstream RoaringBitmap |
| clickhouse-data/src/main/java11/module-info.java | Updates module requirement from org.roaringbitmap to roaringbitmap |
| clickhouse-jdbc/pom.xml | Removes repackaged dependencies, adds upstream RoaringBitmap dependency |
| clickhouse-r2dbc/pom.xml | Removes repackaged org.roaringbitmap dependency and okio relocation |
| clickhouse-client/pom.xml | Removes repackaged org.roaringbitmap dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| requires static org.lz4.java; | ||
| requires static org.slf4j; | ||
| requires static org.roaringbitmap; | ||
| requires static roaringbitmap; |
There was a problem hiding this comment.
The module name should match the upstream library's module-info descriptor. The upstream RoaringBitmap library uses org.roaringbitmap as its module name, not roaringbitmap. This will cause module resolution failures at runtime.
Suggested change
| requires static roaringbitmap; | |
| requires static org.roaringbitmap; |
Contributor
Author
There was a problem hiding this comment.
actually previous declaration is wrong because they defined module like this:
/**
* This module class contains the public packages for the RoaringBitmap library.
*/
module roaringbitmap {
exports org.roaringbitmap;
exports org.roaringbitmap.buffer;
exports org.roaringbitmap.longlong;
exports org.roaringbitmap.insights;
}And org.roaringbitmap is sub module that is exported.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
| <relocation> | ||
| <pattern>okio</pattern> | ||
| <shadedPattern>${shade.base}.okio</shadedPattern> | ||
| </relocation> |
There was a problem hiding this comment.
Stale shade plugin filter references removed artifact
Low Severity
The shade plugin filter at line 319 still references ${project.parent.groupId}:org.roaringbitmap, which corresponds to the com.clickhouse:org.roaringbitmap artifact from the third-party-libraries folder being removed in this PR. The dependency on this artifact was removed from clickhouse-r2dbc/pom.xml, but this filter configuration was not cleaned up. This inconsistency leaves dead configuration that references a non-existent artifact and could cause confusion or unexpected behavior.
Contributor
Author
There was a problem hiding this comment.
this is part of grpc what is not supported.
Contributor
Author
There was a problem hiding this comment.
this is part of grpc what is not supported.
Contributor
Author
There was a problem hiding this comment.
this is part of grpc what is not supported.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
third-party-librariesfolder that contained:io.grpc- GRPC is not supported right now. Dependency is not used anywhere.org.apache.commons.compress- used by client and JDBC driver and already included in shaded jar. No need to publish. No code dependencies.org.congocc- was never used. See 1 beloworg.roaringbitmap- used but also included in shaded jar. No need to publish. No code dependencies.note 1:
org.congoccis alternative to JavaCC21 parser generator. There was an attempt to migrate to the CongoCC https://github.com/ClickHouse/clickhouse-java/pull/1308/files but there are no evidence that it was complete.Closes #2704
Checklist
Delete items not relevant to your PR:
Note
Removes repackaging infrastructure and standardizes on upstream artifacts.
third-party-librariessubtree and.github/workflows/third_party_libs.ymlorg.roaringbitmap:RoaringBitmap(version bumped to1.0.6) and removes repackaged referencesorg.roaringbitmaptoroaringbitmapinclickhouse-datamodule-infosorg.apache.commons:commons-compressdirectly; drops alias artifactpom.xml: removes repackaged deps, updates dependencyManagement, and simplifies JaCoCo profileclient,data,jdbc,r2dbc): remove unused/alias deps, add direct RoaringBitmap where needed, minor comment/cleanupWritten by Cursor Bugbot for commit 8bf9e03. This will update automatically on new commits. Configure here.