Skip to content

chore: 🤖 remove unnecessary aliases (deprecated due to asset name normalisation)#902

Merged
punkbit merged 3 commits intomainfrom
fix/remove-unnecessary-aliases-post-brand-name-normalisation
Mar 10, 2026
Merged

chore: 🤖 remove unnecessary aliases (deprecated due to asset name normalisation)#902
punkbit merged 3 commits intomainfrom
fix/remove-unnecessary-aliases-post-brand-name-normalisation

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 9, 2026

Why?

Remove unnecessary aliases (deprecated due to asset name normalisation)

How?

  • Remove aliases

Preview?

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

🦋 Changeset detected

Latest commit: 16d6cee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Claude finished @punkbit's task in 1m 36s —— View job


Code Review

  • Gather context and read changed files
  • Verify removed aliases against actual asset names
  • Check for any consumers still relying on these aliases

Looks great! Clean and correct removal.

A quick check of the actual logo map (LogosLight.ts) confirms that the removed aliases were pointing to non-existent target names — they were already dead code post-normalization:

Removed alias Was resolving to Actual canonical key
digital_ocean digital-ocean digitalocean
golang go-lang golang
mongodb mongo-db mongodb
mysql my-sql mysql
nodejs node-js nodejs
onelake one-lake onelake
warpstream warp-stream warpstream

The previous normalization PRs (#897, #900) established the non-hyphenated forms as canonical, which made these aliases effectively broken. Removing them is safe and correct — no regression risk.

No changeset needed since no public API behavior changes (the aliases weren't working anyway).

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Claude finished @punkbit's task in 45s —— View job


Code Review

  • Gather context and read changed files
  • Verify removed aliases against actual asset names
  • Check for any consumers still relying on these aliases

Looks great! Clean and correct removal.

Verified against LogosLight.ts — the removed aliases were all pointing to non-existent hyphenated names that were superseded by the normalization in #897 and #900:

Removed alias Was pointing to Actual canonical key
digital_ocean digital-ocean digitalocean
golang go-lang golang
mongodb mongo-db mongodb
mysql my-sql mysql
nodejs node-js nodejs
onelake one-lake onelake
warpstream warp-stream warpstream

These aliases were already broken (resolving to keys that don't exist in the logo map), so removing them is safe with zero regression risk.

One minor note: the changeset is marked as patch, which is appropriate — no working public API was changed.

@punkbit punkbit requested a review from kunalpanchal March 10, 2026 11:31
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Claude finished @punkbit's task in 20s —— View job


Code Review

  • Read changed files
  • Verify removed aliases against actual asset names
  • Check for remaining aliases consistency

Looks great! Clean and correct removal.

The 7 removed aliases in src/components/Assets/config.ts were pointing to hyphenated names (e.g. digital-ocean, go-lang, mongo-db) that no longer exist after the brand name normalization in #897/#900. The canonical keys are now the non-hyphenated forms (digitalocean, golang, etc.), making these aliases effectively broken — removing them is the right call.

The sole remaining alias ('c#' → 'c-sharp') is a genuine special-character alias and correctly stays.

No public API regression — the removed aliases were already non-functional.

@punkbit punkbit requested a review from EvandroLG March 10, 2026 11:32
@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-16nv9zt6a-clickhouse.vercel.app

Built from commit: 21da9e8d337fc78821974a63aa1f9898863cad7b

@punkbit punkbit merged commit 62a0cb7 into main Mar 10, 2026
8 checks passed
@punkbit punkbit deleted the fix/remove-unnecessary-aliases-post-brand-name-normalisation branch March 10, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants