Bug fixs

[AbdelazizBouzidi]

No description provided.

[ClementPinard]

/quack review

[ghost]

Oops, that one is on us 🙃 We'll investigate shortly!

[frgfm]

/quack review

[ghost]

Thanks for the PR 🙏

Other sections

[invalid-eof] detected at generate_sky_masks.py:L106

[print-statement] detected at main_pipeline_no_lidar.py:L77

For a better experience, it's recommended to check the review comments in the tab Files Changed.

---

Feedback is a gift! Quack will adjust your review style when you add reactions to a review comment

[ghost]

The EOF should be a single blank line

Pattern explanation 👈

Adding a blank line as End of File (EOF) is a convention for file processing to mark the end of a character sequence. For more details, feel free to check this resource.

Suggestion

Perhaps we could handle this like so:

Suggested change

---

Quack feedback loop 👍👎

This comment is about [invalid-eof]. Add the following reactions on this comment to let us know if:
- 👍 that comment was on point
- 👀 that doesn't seem right
- 👎 this isn't important for you right now
- 😕 that explanation wasn't clear

[ghost]

Let's avoid print calls in production-ready code

Pattern explanation 👈

print calls can be useful for developping and debugging. But moving to a production-ready system, users can select the logging level they want to display but prints don't offer that flexibility. For more details, feel free to check this resource.

Code example

Here is an example of how this is typically handled:

# print("The payload is empty!")
import logging

logging.warning("The payload is empty!")

---

Quack feedback loop 👍👎

This comment is about [print-statement]. Add the following reactions on this comment to let us know if:
- 👍 that comment was on point
- 👀 that doesn't seem right
- 👎 this isn't important for you right now
- 😕 that explanation wasn't clear