Enable SplashFontRenderer render Unicode char#128
Open
Ecdcaeb wants to merge 10 commits intoCleanroomMC:mainfrom
Open
Enable SplashFontRenderer render Unicode char#128Ecdcaeb wants to merge 10 commits intoCleanroomMC:mainfrom
Ecdcaeb wants to merge 10 commits intoCleanroomMC:mainfrom
Conversation
Collaborator
|
Why base branch is render-system? |
Rongmario
requested changes
Aug 21, 2025
Member
Rongmario
left a comment
Rongmario
left a comment
There was a problem hiding this comment.
Not much API to be had here, just a few places to clear up and it'd be fine to include.
src/main/java/net/minecraftforge/fml/client/SplashProgress.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minecraftforge/fml/client/SplashProgress.java
Outdated
Show resolved
Hide resolved
src/main/java/net/minecraftforge/fml/client/SplashProgress.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable SplashFontRenderer render Unicode char
Open SplashFontRenderer for modder as a early font renderer.
Some mods might render text at loading splash or any other early usages.
Why do I encounter this problem
I noticed that LoadingTips is using
SplashFontRenderer, which does not support UTF-8 chars.However, it is not a issue of
LoadingTips. Cleanroom should allow the using of UTF-8 chars in the splash rendering, although forge does haven't any non-ascii chars to render. Early character rendering is a very common requirement.