Added fixes for output mismatch and returning status code got from ND - #455
Open
jeetugangwar11 wants to merge 7 commits into
Open
Added fixes for output mismatch and returning status code got from ND#455jeetugangwar11 wants to merge 7 commits into
jeetugangwar11 wants to merge 7 commits into
Conversation
…D instead of harcoding 200 for successful operation.
jeetugangwar11
requested review from
akinross,
allenrobel,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
July 29, 2026 08:45
jeetugangwar11
changed the title
allenrobel
reviewed
Jul 29, 2026
allenrobel
left a comment
allenrobel
left a comment
Collaborator
There was a problem hiding this comment.
Code review
One finding, on the vPC-pair setup loop in rm_tasks.yaml. The RETURN_CODE/verbosity changes themselves look correct (status captured immediately after each request, no cross-request leakage; unit and integration assertions match the new behavior).
🤖 Generated with Claude Code
mtarking
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Changes:
Use the HTTP RETURN_CODE provided by the ND response envelope for successful Resource Manager API operations instead of hardcoding 200.
Preserve the response metadata for resource create, update-delete, and delete operations.
Continue using a synthetic 200 response for check-mode and logical operations where no API request is sent.
Preserve per-resource operation status and messages in the response DATA.
Retain the actual ND response code for partial-success failures, such as HTTP 207 Multi-Status.
Test Notes:
Ran the complete Resource Manager unit test suite:
Verified that partial delete responses expose the ND-provided RETURN_CODE: 207.
Verified that API path, verb, payload, response, result, metadata, and diff are returned correctly at -vvv.
Nexus Dashboard: 4.3.1.135.51166
Related ND API Resource Category:
manage
Checklist
Latest commit is rebased from develop with merge conflicts resolved
New or updates to documentation has been made accordingly
Assigned the proper reviewers