Integration: nd_interface_ethernet_access setup probe policy + deploy timeout - #454
Open
allenrobel wants to merge 2 commits into
Open
Integration: nd_interface_ethernet_access setup probe policy + deploy timeout#454allenrobel wants to merge 2 commits into
allenrobel wants to merge 2 commits into
Conversation
…cy (#408) The check-mode re-query probe in setup.yaml used a bare `policy:` (null), which the policy-required-on-create preflight (issue #350, PR #362) now rejects whenever the preceding cleanup actually removed the interface, failing the target during setup. Send `policy: {}` instead, matching the fix already applied to nd_interface_ethernet_trunk_host in PR #360. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QjkaNkVgf4yTanJVQB9ua
…le_defaults The shared argspec's `timeout` default (30s) propagates through sender_nd.set_params() into the httpapi plugin, which overwrites persistent_command_timeout on every task -- inventory-level ansible_command_timeout can never take effect. The multi-switch bulk interfaceActions/deploy in the overridden phase exceeds 30s on the 9000v testbed, killing the run mid-deploy. Adopt the same target-scoped module_defaults timeout the port-channel targets already use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QjkaNkVgf4yTanJVQB9ua
allenrobel
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
July 28, 2026 20:24
allenrobel
changed the title
allenrobel
added
ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Fixes #408
Proposed Changes
tasks/setup.yaml: the check-mode re-query probe now sends an empty-but-presentpolicy: {}instead of a barepolicy:(null), which the policy-required-on-create preflight (Interface create accepts a policy-less config item (config_data optional, no create-time validator) #350, PR Add policy-required-on-create preflight for interface modules (#350) #362) rejects whenever the preceding cleanup actually removed the interface. Matches the fix already applied tond_interface_ethernet_trunk_hostin PR Enforce storm-control percentage/pps mutual exclusivity (#351) #360, including the explanatory comment.tasks/main.yaml: wrap the test block inmodule_defaults: cisco.nd.nd_interface_ethernet_access: timeout: 300, matching the port-channel targets. The shared argspec'stimeoutdefault (30s) propagates throughsender_nd.set_params()into the httpapi plugin, which overwritespersistent_command_timeouton every task — so inventory-levelansible_command_timeoutcan never take effect, and the multi-switch bulkinterfaceActions/deployin the overridden phase exceeds 30s on the 9000v testbed.Scope audit re-run for #408: after this change, no integration target contains a truly null
policy:key (apolicy:line whose next non-comment line is not more-deeply indented).Test Notes
nd_interface_ethernet_accessnetwork-integration target run green against the live SITE1 lab (ND 4.2.1, 9000v testbed), including the overridden-phase deploy that previously timed out; the setup cleanup also reconciled the pending intent orphaned by the earlier mid-deploy timeout (setup task reportedchanged)ansible-test sanity --test yamllintpasses on both changed files (nd-dev container machine)Cisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist
🤖 Generated with Claude Code