Address PR #269/#270 doc review comments; enforce netflow_monitor with netflow

[allenrobel]

Related Issue(s)

None — follow-ups to review comments on merged PRs #269 and #270 (threads linked below).

Proposed Changes

• Parenthesize the policyType references in module DOCUMENTATION — (accessPoHost) / (trunkPoHost) — and drop "querying" from the access module description, per review suggestions:
  • nd_interface_port_channel_access #269 (comment)
  • nd_interface_port_channel_access #269 (comment)
  • nd_interface_port_channel_access #269 (comment)
  • nd_interface_port_channel_access #269 (comment)
  • nd_interface_port_channel_trunk_host #270 (comment)
  • nd_interface_port_channel_trunk_host #270 (comment)
• Document that netflow_monitor is required when netflow=true in both modules' DOCUMENTATION and model field descriptions, and enforce it with the same model_validator that nd_interface_svi uses (_validate_netflow_monitor_present), so an incomplete netflow policy fails early with a clear error instead of deferring the outcome to ND. Per nd_interface_port_channel_access #269 (comment).
• Unit tests for the new validator in both policy models.

Test Notes

• Unit tests pass: ndpytest tests/unit/module_utils/models/test_port_channel_access_interface.py tests/unit/module_utils/models/test_port_channel_trunk_host_interface.py — 302 passed (includes 2 new validator tests).
• ndlint (ansible-lint, production profile) passes on both modules.
• black, isort, pylint, mypy run on all changed files — no new findings (remaining pylint/mypy messages are pre-existing import-resolution noise, identical on untouched files).
• DOCUMENTATION blocks re-parsed as YAML to verify the doc edits.

Cisco Nexus Dashboard Version

4.2

Related ND API Resource Category

• analyze
• infra
• manage
• onemanage
• other

Checklist

• Latest commit is rebased from develop with merge conflicts resolved
• New or updates to documentation has been made accordingly
• Assigned the proper reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01Deb5UWoTfAZa6kq7khAEu6

[Copilot]

Pull request overview

This PR follows up on prior doc-review threads for the port-channel access/trunk host interface modules by clarifying how the policyType is referenced in module DOCUMENTATION and by enforcing a model-level constraint for Netflow configuration consistency.

Changes:

• Updates module DOCUMENTATION wording to parenthesize policyType references (e.g., (accessPoHost), (trunkPoHost)) and removes “querying” from the access module description.
• Documents that netflow_monitor is required when netflow=true and enforces this with a Pydantic model_validator in both policy models.
• Adds unit tests covering the new netflow/netflow_monitor validation behavior for both access and trunk host policy models.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/unit/module_utils/models/test_port_channel_trunk_host_interface.py	Adds unit test asserting netflow_monitor is required when netflow=True.
tests/unit/module_utils/models/test_port_channel_access_interface.py	Adds unit test asserting netflow_monitor is required when netflow=True.
plugins/modules/nd_interface_port_channel_trunk_host.py	Updates DOCUMENTATION wording and documents netflow_monitor requirement when netflow=true.
plugins/modules/nd_interface_port_channel_access.py	Updates DOCUMENTATION wording, removes “querying” mention, and documents netflow_monitor requirement when netflow=true.
plugins/module_utils/models/interfaces/port_channel_trunk_host_interface.py	Adds model_validator to reject netflow=True without netflow_monitor; updates field description accordingly.
plugins/module_utils/models/interfaces/port_channel_access_interface.py	Adds model_validator to reject netflow=True without netflow_monitor; updates field description accordingly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gmicol]

LGTM