Skip to content

nd_interface_ethernet_access: align deploy control to config_actions.deploy - #367

Open
allenrobel wants to merge 2 commits into
developfrom
align-ethernet-access-config-actions-deploy
Open

nd_interface_ethernet_access: align deploy control to config_actions.deploy#367
allenrobel wants to merge 2 commits into
developfrom
align-ethernet-access-config-actions-deploy

Conversation

@allenrobel

@allenrobel allenrobel commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Related Issue(s)

Closes #365

Also checks off the #384 task-1 box for this module: its argspec imports now come from nd_argument_specs.py instead of the legacy nd.py.

Proposed Changes

Align nd_interface_ethernet_access deploy control with the convention used by the unmerged
interface modules: replace the flat top-level deploy boolean with a config_actions dict whose
single key is deploy.

Deploy scope and batching are unchanged (interface-scope interfaceActions/deploy, one bulk call per run);
only the toggle moves under config_actions.

No deprecation/changelog fragment: the module is unreleased (released changelog stops at 1.2.0;
galaxy 1.5.0), so nothing shipped is broken.

Test Notes

  • ndblack --check / ndisort --check-only: clean.
  • ndpylint / ndmypy: no new findings from this change. Remaining messages are pre-existing baseline
    in untouched code (missing-module-docstring, import-position, existing TODOs, and the environmental
    ansible_collections.* import-resolution errors).
  • ndtest --test validate-modules plugins/modules/nd_interface_ethernet_access.py: passes (exit 0) —
    confirms DOCUMENTATION suboptions match the fragment-built argspec options.
  • ndpytest tests/unit/module_utils/orchestrators/test_ethernet_access_interface.py tests/unit/module_utils/test_nd_argument_specs.py: 39 passed.
  • Integration merged.yaml no-deploy task updated to the new param shape.

Cisco Nexus Dashboard Version

4.2.1

Related ND API Resource Category

  • analyze
  • infra
  • manage
  • onemanage
  • other

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

🤖 Generated with Claude Code

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the nd_interface_ethernet_access module’s deploy toggle with the convention used by the other interface modules by moving the deploy boolean under a config_actions.deploy suboption, while keeping deploy scope/batching behavior unchanged (still interface-scope interfaceActions/deploy and a single bulk deploy call per run).

Changes:

  • Replaced the top-level deploy module option with config_actions: { deploy: <bool> } in DOCUMENTATION/EXAMPLES and the module argument spec.
  • Updated the module runtime to read config_actions.deploy (defaulting to true) and wire it to model_orchestrator.deploy.
  • Updated the integration “no deploy” task to use the new parameter shape.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugins/modules/nd_interface_ethernet_access.py Moves deploy control under config_actions.deploy across docs, examples, argspec, and runtime read site.
tests/integration/targets/nd_interface_ethernet_access/tasks/merged.yaml Updates the no-deploy integration task to pass config_actions.deploy: false.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenrobel
allenrobel force-pushed the align-ethernet-access-config-actions-deploy branch from 7fa8a07 to 09f18b1 Compare June 30, 2026 16:20
@allenrobel allenrobel self-assigned this Jul 1, 2026
@allenrobel allenrobel added 2.0.0 Release 2.0.0 ready for review Submitter is requesting a PR review and removed ready for review Submitter is requesting a PR review labels Jul 1, 2026
@allenrobel
allenrobel marked this pull request as draft July 2, 2026 19:20
@allenrobel
allenrobel force-pushed the align-ethernet-access-config-actions-deploy branch from 09f18b1 to 5a4ef2f Compare July 3, 2026 01:34
@allenrobel
allenrobel force-pushed the align-ethernet-access-config-actions-deploy branch 2 times, most recently from a558548 to d2b93b6 Compare July 13, 2026 17:09
@sivakasi-cisco sivakasi-cisco added the nac01 NaC ND release 0.0.1 label Jul 14, 2026
@allenrobel
allenrobel force-pushed the align-ethernet-access-config-actions-deploy branch 3 times, most recently from c195e8f to 315ae68 Compare July 22, 2026 16:12
@allenrobel
allenrobel marked this pull request as ready for review July 24, 2026 18:35
@allenrobel allenrobel added the ready for review Submitter is requesting a PR review label Jul 24, 2026
allenrobel and others added 2 commits July 27, 2026 13:02
…deploy

Replace the flat top-level `deploy` boolean with a `config_actions` dict
carrying a single `deploy` key, matching the convention already used by the
unmerged interface modules (svi, ethernet_trunk_host, subinterface_managed,
subinterface_unmanaged).

Changes DOCUMENTATION, EXAMPLES, the argument_spec, and the read site. No
deprecation/changelog fragment: the module is unreleased (released changelog
stops at 1.2.0; galaxy 1.5.0), so nothing shipped is broken.

Closes #365

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H5FaXWEXvkgJUrUBZbfdFA
…ment

Now that #387 is merged, build the `config_actions` block via
`config_actions_spec(include=("deploy",))` from `nd_argument_specs.py`
instead of the hand-written dict (which the fragment reproduces
byte-for-byte), and re-point the `nd_argument_spec` import from the
legacy `nd.py` to `nd_argument_specs.py` — completing the #384 task-1
checkbox for this module.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TnSktMFZGRafkf5GbuBwwm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.0.0 Release 2.0.0 nac01 NaC ND release 0.0.1 ready for review Submitter is requesting a PR review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nd_interface_ethernet_access - align deploy control to config_actions.deploy

3 participants