nd_interface_ethernet_access: align deploy control to config_actions.deploy - #367
Open
allenrobel wants to merge 2 commits into
Open
nd_interface_ethernet_access: align deploy control to config_actions.deploy#367allenrobel wants to merge 2 commits into
allenrobel wants to merge 2 commits into
Conversation
allenrobel
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
June 30, 2026 01:12
There was a problem hiding this comment.
Pull request overview
This PR aligns the nd_interface_ethernet_access module’s deploy toggle with the convention used by the other interface modules by moving the deploy boolean under a config_actions.deploy suboption, while keeping deploy scope/batching behavior unchanged (still interface-scope interfaceActions/deploy and a single bulk deploy call per run).
Changes:
- Replaced the top-level
deploymodule option withconfig_actions: { deploy: <bool> }in DOCUMENTATION/EXAMPLES and the module argument spec. - Updated the module runtime to read
config_actions.deploy(defaulting totrue) and wire it tomodel_orchestrator.deploy. - Updated the integration “no deploy” task to use the new parameter shape.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plugins/modules/nd_interface_ethernet_access.py |
Moves deploy control under config_actions.deploy across docs, examples, argspec, and runtime read site. |
tests/integration/targets/nd_interface_ethernet_access/tasks/merged.yaml |
Updates the no-deploy integration task to pass config_actions.deploy: false. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenrobel
force-pushed
the
align-ethernet-access-config-actions-deploy
branch
from
June 30, 2026 16:20
7fa8a07 to
09f18b1
Compare
allenrobel
marked this pull request as draft
July 2, 2026 19:20
allenrobel
force-pushed
the
align-ethernet-access-config-actions-deploy
branch
from
July 3, 2026 01:34
09f18b1 to
5a4ef2f
Compare
allenrobel
force-pushed
the
align-ethernet-access-config-actions-deploy
branch
2 times, most recently
from
July 13, 2026 17:09
a558548 to
d2b93b6
Compare
allenrobel
force-pushed
the
align-ethernet-access-config-actions-deploy
branch
3 times, most recently
from
July 22, 2026 16:12
c195e8f to
315ae68
Compare
allenrobel
marked this pull request as ready for review
July 24, 2026 18:35
4 tasks
…deploy Replace the flat top-level `deploy` boolean with a `config_actions` dict carrying a single `deploy` key, matching the convention already used by the unmerged interface modules (svi, ethernet_trunk_host, subinterface_managed, subinterface_unmanaged). Changes DOCUMENTATION, EXAMPLES, the argument_spec, and the read site. No deprecation/changelog fragment: the module is unreleased (released changelog stops at 1.2.0; galaxy 1.5.0), so nothing shipped is broken. Closes #365 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5FaXWEXvkgJUrUBZbfdFA
…ment Now that #387 is merged, build the `config_actions` block via `config_actions_spec(include=("deploy",))` from `nd_argument_specs.py` instead of the hand-written dict (which the fragment reproduces byte-for-byte), and re-point the `nd_argument_spec` import from the legacy `nd.py` to `nd_argument_specs.py` — completing the #384 task-1 checkbox for this module. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TnSktMFZGRafkf5GbuBwwm
allenrobel
force-pushed
the
align-ethernet-access-config-actions-deploy
branch
from
July 27, 2026 23:17
48c6e6b to
e626adb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Closes #365
Also checks off the #384 task-1 box for this module: its argspec imports now come from
nd_argument_specs.pyinstead of the legacynd.py.Proposed Changes
Align
nd_interface_ethernet_accessdeploy control with the convention used by the unmergedinterface modules: replace the flat top-level
deployboolean with aconfig_actionsdict whosesingle key is
deploy.deploy:option replaced byconfig_actions:(dict) with adeploysuboption (type: bool, defaulttrue).deploy: false→config_actions: { deploy: false }.argument_spec:deploy=dict(...)→config_actions_spec(include=("deploy",)), the shared fragment added by Relocate nd_argument_spec to nd_argument_specs.py; add config_actions_spec fragment #387(reproduces the deploy-only block hand-written in the sibling interface modules byte-for-byte).
nd_argument_specimport re-pointed from legacynd.pytond_argument_specs.py(Tracking: Gen-3 argspec imports via nd_argument_specs.py #384 task 1 for this module).config_actions.deploy(defaulttrue) and setsorchestrator.deploy.Deploy scope and batching are unchanged (interface-scope
interfaceActions/deploy, one bulk call per run);only the toggle moves under
config_actions.No deprecation/changelog fragment: the module is unreleased (released changelog stops at 1.2.0;
galaxy 1.5.0), so nothing shipped is broken.
Test Notes
ndblack --check/ndisort --check-only: clean.ndpylint/ndmypy: no new findings from this change. Remaining messages are pre-existing baselinein untouched code (missing-module-docstring, import-position, existing TODOs, and the environmental
ansible_collections.*import-resolution errors).ndtest --test validate-modules plugins/modules/nd_interface_ethernet_access.py: passes (exit 0) —confirms DOCUMENTATION
suboptionsmatch the fragment-built argspecoptions.ndpytest tests/unit/module_utils/orchestrators/test_ethernet_access_interface.py tests/unit/module_utils/test_nd_argument_specs.py: 39 passed.merged.yamlno-deploy task updated to the new param shape.Cisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist
🤖 Generated with Claude Code