fix(epub): resolve percent-encoded NCX targets - #64
Open
Technofrikus wants to merge 1 commit into
Open
Technofrikus wants to merge 1 commit into
Technofrikus wants to merge 1 commit into
Conversation
Owner
|
Can you give me the title of the book so I can check this out myself? |
Author
|
It may be in this particular epub, not sure, so here it is: https://nx47798.your-storageshare.de/s/WZYqY6n3YLbefQp Edit: weird phrasing. I meant you probably would not find the specific epub of this book, other epubs might not have this problem, dont know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had one epub where the chapter selection did not work. Even though the epub had chapters. There were percent signs in the NCX paths wich the parser for converting to mrb had problems with, so the chapters werent added.
I tested this on my X3 and now the chapters work.
This was made with AI, tbh I dont fully understand the solution but hope that ChatGPT 5.6 Terra did a good job.
Thanks for this awesome firmware! The other ones are so slow and full of features I dont need. This one is snappy.
I made some speed improvements in my fork (converting fonts, turning on and off), if you are interested I could make PRs here as well. Not sure how active you want or can be at the moment.