Skip to content

fix(query): avoid S3 notification standalone target FPs #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omribz156 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(query): avoid S3 notification standalone target FPs #8053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions assets/queries/terraform/aws/s3_bucket_notifications_disabled/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,6 @@ package Cx
import data.generic.common as common_lib
import data.generic.terraform as tf_lib

CxPolicy[result] {
# Cases of "SNS Topic" or "SQS Queue" or "Lambda Function" with aws_s3_bucket_notification undefined
s3 := input.document[i].resource[type][name]
types := ["aws_sns_topic","aws_sqs_queue","aws_lambda_function"]
type == types[_]

not common_lib.valid_key(input.document[i].resource, "aws_s3_bucket_notification")

result := {
"documentId": input.document[i].id,
"resourceType": type,
"resourceName": tf_lib.get_specific_resource_name(s3, "aws_s3_bucket_notification", type),
"searchKey": sprintf("%s[%s]",[type,name]),
"issueType": "MissingAttribute",
"keyExpectedValue": "'aws_s3_bucket_notification' should be defined and not null",
"keyActualValue": "'aws_s3_bucket_notification' is undefined or null",
"searchLine": common_lib.build_search_line(["resource", type, name], []),
}
}



CxPolicy[result] {
# Cases of "SNS Topic" or "SQS Queue" or "Lambda Function" not referenced in aws_s3_bucket_notification
s3 := input.document[i].resource[type][name]
Expand Down
2 changes: 1 addition & 1 deletion ...notifications_disabled/test/positive10.tf → ..._notifications_disabled/test/negative7.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
resource "aws_sns_topic" "topic1" {
name = "s3-event-notification-topic"
policy = data.aws_iam_policy_document.topic.json
}
}
2 changes: 1 addition & 1 deletion ...notifications_disabled/test/positive11.tf → ..._notifications_disabled/test/negative8.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
resource "aws_sqs_queue" "queue" {
name = "s3-event-notification-queue"
policy = data.aws_iam_policy_document.queue.json
}
}
2 changes: 1 addition & 1 deletion ...notifications_disabled/test/positive12.tf → ..._notifications_disabled/test/negative9.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ resource "aws_lambda_function" "func" {
role = aws_iam_role.iam_for_lambda.arn
handler = "exports.example"
runtime = "nodejs20.x"
}
}
18 changes: 0 additions & 18 deletions ...queries/terraform/aws/s3_bucket_notifications_disabled/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,5 @@
"severity": "LOW",
"line": 6,
"fileName": "positive9.tf"
},
{
"queryName": "S3 bucket notifications disabled",
"severity": "LOW",
"line": 1,
"fileName": "positive10.tf"
},
{
"queryName": "S3 bucket notifications disabled",
"severity": "LOW",
"line": 1,
"fileName": "positive11.tf"
},
{
"queryName": "S3 bucket notifications disabled",
"severity": "LOW",
"line": 1,
"fileName": "positive12.tf"
}
]
Loading