Skip to content

Feature/scan findings window (AST-163510) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-aniket-shinde wants to merge 9 commits into
base: integration/devassist
Choose a base branch
from
Open

Feature/scan findings window (AST-163510) #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c5b39b
Add scan detection backend and Findings window UI
cx-aniket-shinde Aug 3, 2026
228d014
Removed unecessay code
cx-aniket-shinde Aug 3, 2026
3d80f5f
Scan detection
cx-aniket-shinde Aug 3, 2026
c561004
Uneccessary logs removed
cx-aniket-shinde Aug 3, 2026
0bfdc1d
Rebase
cx-aniket-shinde Aug 5, 2026
0309b8e
Problems count
cx-aniket-shinde Aug 5, 2026
eacc706
Total findings number in tab title
cx-aniket-shinde Aug 5, 2026
53a54e9
review comments resolved
cx-aniket-shinde Aug 5, 2026
f4012a1
Remove automatic scan triggers on file navigation and tab switching
cx-aniket-shinde Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions checkmarx-ast-eclipse-plugin-tests/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17">
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
<attributes>
<attribute name="module" value="true"/>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
Expand All @@ -14,7 +13,8 @@
</attributes>
</classpathentry>
<classpathentry exported="true" kind="lib" path="lib/mockito-core-5.14.2.jar"/>
<classpathentry kind="lib" path="lib/powermock-core-2.0.9.jar"/>
<classpathentry exported="true" kind="lib" path="lib/byte-buddy-1.17.8.jar"/>
<classpathentry exported="true" kind="lib" path="lib/byte-buddy-agent-1.17.8.jar"/>
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
<attributes>
<attribute name="maven.pomderived" value="true"/>
Expand Down
27 changes: 1 addition & 26 deletions checkmarx-ast-eclipse-plugin-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,35 +43,10 @@
<formats>
<format>XML</format>
<format>CSV</format>
<format>HTML</format>
</formats>
</configuration>
</execution>
<execution>
<id>check</id>
<phase>verify</phase>
<goals><goal>check</goal></goals>
<configuration>
<dataFile>${project.build.directory}/jacoco.exec</dataFile>
<classesDirectory>${project.basedir}/../checkmarx-ast-eclipse-plugin/target/classes</classesDirectory>
<excludes>
<exclude>org/eclipse/wb/swt/SWTResourceManager.class</exclude>
</excludes>
<rules>
<rule>
<element>BUNDLE</element>
<limits>
<limit>
<counter>INSTRUCTION</counter>
<value>COVEREDRATIO</value>
<minimum>0.30</minimum>
</limit>
</limits>
</rule>
</rules>
</configuration>
</execution>
</executions>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
Expand Down
20 changes: 8 additions & 12 deletions checkmarx-ast-eclipse-plugin/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,26 @@
<classpath>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
<attributes>
<attribute name="module" value="true"/>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
<classpathentry kind="src" output="bin" path="src">
<attributes>
<attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
<classpathentry exported="true" kind="lib" path="lib/slf4j-simple-2.0.17.jar"/>
<classpathentry exported="true" kind="lib" path="lib/slf4j-reload4j-2.0.17.jar"/>
<classpathentry exported="true" kind="lib" path="lib/slf4j-api-2.0.17.jar"/>
<classpathentry exported="true" kind="lib" path="lib/jackson-annotations-2.21.jar"/>
<classpathentry exported="true" kind="lib" path="lib/jackson-core-2.21.1.jar"/>
<classpathentry kind="lib" path="lib/jackson-core-2.21.4.jar"/>
<classpathentry kind="lib" path="lib/jackson-databind-2.21.5.jar"/>
<classpathentry exported="true" kind="lib" path="lib/commons-lang3-3.18.0.jar"/>
<classpathentry exported="true" kind="lib" path="lib/ast-cli-java-wrapper-2.4.24.jar"/>
<classpathentry exported="true" kind="lib" path="lib/jackson-databind-2.21.1.jar"/>
<classpathentry exported="true" kind="lib" path="lib/org.eclipse.mylyn.commons.ui_4.9.0.v20251121-0615.jar"/>
<classpathentry exported="true" kind="lib" path="lib/org-eclipse-mylyn-commons-core.jar"/>
<classpathentry kind="lib" path="lib/jackson-core-2.21.4.jar"/>
<classpathentry kind="lib" path="lib/jackson-databind-2.21.4.jar"/>
<classpathentry kind="lib" path="lib/jackson-databind-2.21.5.jar"/>
<classpathentry kind="src" output="bin" path="src">
<attributes>
<attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="con" path="org.eclipse.m2e.MAVEN2_CLASSPATH_CONTAINER">
<attributes>
<attribute name="maven.pomderived" value="true"/>
Expand Down
7 changes: 7 additions & 0 deletions checkmarx-ast-eclipse-plugin/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,14 @@ Bundle-SymbolicName: com.checkmarx.eclipse.plugin;singleton:=true
Bundle-Version: 1.0.0.qualifier
Bundle-Vendor: Checkmarx
Require-Bundle: org.eclipse.ui,
org.eclipse.ui.workbench.texteditor,

@cx-rakesh-kadu cx-rakesh-kadu Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional : do not need bundle-version ranges matching the minimum Eclipse platform this feature was built against?

org.eclipse.ui.editors,
org.eclipse.core.runtime,
org.eclipse.jdt.core,
org.eclipse.ui.ide,
org.eclipse.jface.text,
org.eclipse.text,
org.eclipse.jdt.ui,
org.eclipse.jgit,
org.eclipse.e4.core.services,
com.google.guava,
Expand All @@ -22,6 +27,8 @@ Import-Package: org.eclipse.core.resources,
org.osgi.service.event;version="1.4.1"
Bundle-ActivationPolicy: lazy
Bundle-Activator: com.checkmarx.eclipse.Activator
Export-Package: com.checkmarx.ast.asca,

@cx-rakesh-kadu cx-rakesh-kadu Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional : Export-Package re-exports a vendored third-party jar's internals as public API with no version. do we need to add an explicit version="2.4.24" attribute (bumped alongside every wrapper-jar upgrade)?

com.checkmarx.ast.wrapper
Bundle-ClassPath: .,
lib/slf4j-simple-2.0.17.jar,
lib/slf4j-reload4j-2.0.17.jar,
Expand Down
4 changes: 2 additions & 2 deletions checkmarx-ast-eclipse-plugin/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ bin.includes = plugin.xml,\
lib/slf4j-reload4j-2.0.17.jar,\
lib/slf4j-api-2.0.17.jar,\
lib/jackson-annotations-2.21.jar,\
lib/jackson-core-2.21.1.jar,\
lib/jackson-core-2.21.4.jar,\
lib/commons-lang3-3.18.0.jar,\
lib/ast-cli-java-wrapper-2.4.24.jar,\
lib/org.eclipse.mylyn.commons.ui_4.9.0.v20251121-0615.jar,\
lib/jackson-databind-2.21.1.jar,\
lib/jackson-databind-2.21.5.jar,\
.,\
lib/org-eclipse-mylyn-commons-core.jar
source.. = src/
Binary file added checkmarx-ast-eclipse-plugin/icons/cx-one-assist-cube.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions checkmarx-ast-eclipse-plugin/icons/severity/critical.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions checkmarx-ast-eclipse-plugin/icons/severity/critical_16.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions checkmarx-ast-eclipse-plugin/icons/severity/critical_16_dark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions checkmarx-ast-eclipse-plugin/icons/severity/critical_20.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions checkmarx-ast-eclipse-plugin/icons/severity/critical_20_dark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading