Fix/gaia static route mask length - #275
Merged
chkp-tomerassa merged 2 commits intoSep 1, 2026
Merged
Conversation
d.GetOk("mask_length") treats an explicit 0 the same as unset, since 0 is
the Go zero value for TypeInt. mask_length is Required and accepts 0-32,
so a route with mask_length=0 (e.g. a default route) silently omitted
mask-length from the request, and the Gaia API rejected it as missing.
Switch to GetOkExists, which distinguishes an explicit 0 from "not set",
matching the pattern already used for ping/scope_local in this file.
Not meant to be part of this fix's commit history.
chkp-tomerassa
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.