Cellml download retry#40
Open
kwabenantim wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent CI configuration failures (Issue #39) by making the CellML fetch step more robust during CMake configuration, reducing the likelihood of GitHub rate limiting and ensuring configuration fails fast when CellML retrieval cannot succeed.
Changes:
- Switch CellML retrieval from 14 individual
file(DOWNLOAD ...)calls to a single GitHub tarball download at a pinned revision. - Add bounded retry logic with backoff for the archive download, and make download/unpack failures fatal to configuration.
- Update legacy documentation links in CMake and README to the current Chaste documentation site.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Reworks CellML fetching to download + unpack a single archive with retries and fatal failure on error. |
| README.md | Updates the “Getting Started” documentation link to the new Chaste docs site. |
| apps/CMakeLists.txt | Updates legacy Chaste CMake build guide link. |
| test/CMakeLists.txt | Updates legacy Chaste CMake build guide link. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kwabenantim
marked this pull request as ready for review
July 25, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39