add: support for private app#49
Open
vantis-zh wants to merge 1 commit into
Open
Conversation
ryankazokas
suggested changes
Jul 29, 2021
ryankazokas
left a comment
ryankazokas
left a comment
Contributor
There was a problem hiding this comment.
I think you just need to add some test coverage. Everything else here looks good.
|
|
||
| private Invocation.Builder buildCall(WebTarget webTarget) { | ||
| Invocation.Builder builder = webTarget.request(MediaType.APPLICATION_JSON); | ||
| if (null != apiKey && null != password) { |
Contributor
There was a problem hiding this comment.
Thanks for adding this. Can you add or update a unit test to use this flow so we can get some coverage for regression.
| @@ -0,0 +1,62 @@ | |||
| package com.shopify; | |||
Contributor
There was a problem hiding this comment.
Thanks for testing out generating the authorization header, but is this needed? Can you remove if not? I see that your code does exactly was is described here:
https://shopify.dev/apps/auth/basic-http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added supports for private apps who call api through basic auth.