Skip to content

Conversation

@nsemets
Copy link
Collaborator

@nsemets nsemets commented Jan 7, 2026

  • Ticket: [ENG-9838]
  • Feature flag: n/a

Summary of Changes

  1. Changed API for search users in add contributors/moderators dialogs.
  2. Added unit tests.

Screenshot(s)

image image

@nsemets
Copy link
Collaborator Author

nsemets commented Jan 7, 2026

Note: Due to unexpected search behavior. Where matches are found not only in the name and identifier fields but also in highlighted text. It was proposed to send two requests whenever the query is a single word (=5 characters, to limit wasteful requests) and let the backend determine whether it is an identifier.

One request would use cardSearchFilter[sameAs]=https://osf.example/blarg (with the current domain from the environment settings used as the prefix). This request should usually return zero or one result, be faster than a text search, and any result should be treated as highest relevance.

The second request, cardSearchText[name]=blarg*, should always run as well, in case an OSF ID collides with a name.

This approach means we won’t support search by ORCID ID.

@nsemets nsemets requested a review from brianjgeiger January 7, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant