Add standard error to exception message#140
Open
allisonChilton wants to merge 1 commit intoCastXML:developfrom
Open
Add standard error to exception message#140allisonChilton wants to merge 1 commit intoCastXML:developfrom
allisonChilton wants to merge 1 commit intoCastXML:developfrom
Conversation
allisonChilton
commented
Apr 10, 2021
iMichka
approved these changes
Apr 12, 2024
The rationale is that when castxml has an error it raises a RuntimeError to the user with the message. However, the message only contains the stdout from castxml - this makes the RuntimeError contain no information about what actually went wrong. This change allows the user to add error handling to their applications based on what went wrong with castxml (such as changing their include directories, etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rationale is that when castxml has an error it raises a RuntimeError to the user with the message.
However, the message only contains the stdout from castxml - this makes the RuntimeError contain no information about what actually went wrong.
This change allows the user to add error handling to their applications based on what went wrong with castxml (such as changing their include directories, etc)