Skip to content

Add console command to reveal cave and dungeon names #9495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kiousu wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add console command to reveal cave and dungeon names #9495

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
99f51dd
Add console command to reveal cave and dungeon names
Jan 12, 2026
db5fbcb
Merge branch 'Card-Forge:master' into master
Kiousu Jan 30, 2026
d673426
Allow reveal command to accept POI types
Kiousu Jan 30, 2026
d023fb2
Merge branch 'Card-Forge:master' into master
Kiousu Feb 4, 2026
a253c0a
added city as an alias of town
Kiousu Feb 4, 2026
b06bdf4
Merge branch 'Card-Forge:master' into master
Kiousu Feb 5, 2026
ca9819d
Merge branch 'master' into master
Kiousu Feb 6, 2026
90a5332
Merge branch 'Card-Forge:master' into master
Kiousu Feb 6, 2026
2cac37a
Merge branch 'Card-Forge:master' into master
Kiousu Feb 9, 2026
87ab265
Merge branch 'Card-Forge:master' into master
Kiousu Feb 10, 2026
6965333
Merge branch 'Card-Forge:master' into master
Kiousu Feb 12, 2026
51225ea
Merge branch 'Card-Forge:master' into master
Kiousu Feb 13, 2026
7e74ac5
Merge branch 'master' into master
Kiousu Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions forge-gui-mobile/src/forge/adventure/stage/ConsoleCommandInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.function.Function;
import java.util.regex.Matcher;
Expand Down Expand Up @@ -338,6 +340,50 @@ private ConsoleCommandInterpreter() {
System.out.println("POI Names - Types\n" + String.join("\n", poiNames));
return "POI lists dumped to stdout.";
});
registerCommand(new String[]{"reveal"}, s -> {
WorldSave save = WorldSave.getCurrentSave();
if (save == null || save.getWorld() == null) {
return "No world loaded.";
}
if (s.length < 1) {
return "Please specify at least one PointOfInterest type (e.g. \"reveal cave\", \"reveal dungeon\", \"reveal town\", \"reveal capital\").";
}
HashSet<String> types = new HashSet<>();
for (String type : s) {
String normalized = type.toLowerCase();
if (normalized.endsWith("ies")) {
normalized = normalized.substring(0, normalized.length() - 3) + "y";
} else if (normalized.endsWith("s") && normalized.length() > 1) {
normalized = normalized.substring(0, normalized.length() - 1);
}
Comment on lines +354 to +358
Copy link
Contributor

@Jetz72 Jetz72 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think including logic for normalizing plurals and synonyms is a bit excessive for a developer console.

Copy link
Author

@Kiousu Kiousu Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t see this as adding “smart” logic to the console — just making it less brittle.
The previous review itself referred to the town POI as a “city,” which highlights the core issue: even contributors don’t reliably remember the exact internal identifiers. Requiring exact string matches makes the console fragile and forces people to look up data definitions.
The normalization here is intentionally minimal (simple plurals and a few explicit aliases like city → town). It’s not general NLP — just a thin layer to prevent avoidable friction.

Copy link
Contributor

@Jetz72 Jetz72 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous review itself referred to the town POI as a “city,” which highlights the core issue: even contributors don’t reliably remember the exact internal identifiers. Requiring exact string matches makes the console fragile and forces people to look up data definitions.

The previous review wasn't from a contributor. As far as I can tell, that was their first comment on any Forge PR or issue.

I generally agree that having to look these kinds of parameters up is annoying, but haven't you resolved that by including the list of examples in your error message?

Copy link
Author

@Kiousu Kiousu Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. My mistake.

That’s fair. I'll remove the normalization when I get the chance.

if ("city".equals(normalized)) {
normalized = "town";
}
if (!normalized.isEmpty()) {
types.add(normalized);
}
}
if (types.isEmpty()) {
return "Please specify at least one PointOfInterest type (e.g. \"reveal cave\", \"reveal dungeon\", \"reveal town\", \"reveal capital\").";
}
int revealed = 0;
for (PointOfInterest poi : save.getWorld().getAllPointOfInterest()) {
PointOfInterestData data = poi.getData();
if (data == null || data.type == null) {
continue;
}
if (!types.contains(data.type.toLowerCase())) {
continue;
}
if (!save.getPointOfInterestChanges(poi.getID()).isVisited()) {
save.getPointOfInterestChanges(poi.getID()).visit();
revealed++;
}
}
ArrayList<String> sortedTypes = new ArrayList<>(types);
Collections.sort(sortedTypes);
return "Revealed " + revealed + " " + String.join("/", sortedTypes) + " names on the map.";
});
registerCommand(new String[]{"setColorID"}, s -> {
if (s.length < 1)
return "Please specify color ID: Valid choices: B, G, R, U, W, C. Example:\n\"setColorID G\"";
Expand Down