Merged
Conversation
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
Contributor
|
If someone wants to patch up the merge conflict, seems like a straightforward enough add. Guess it just fell through the cracks. |
Eradev
force-pushed
the
ExposeLandTypesCount
branch
from
62e384b to
f3ecea0
Compare
Jetz72
previously approved these changes
Feb 20, 2026
Contributor
|
I was mostly thinking about our approach to adding stuff for custom cards - if there was a way to make this more generic |
Contributor
|
I'm not sure there's a good way to make it generic without refactoring a bunch of card scripts. Could just search for the substring "Type" then inspect whatever's before it but that's kinda ugly. I'll just slap on a comment. But I do think this is worth extra consideration in future cases when we clean up unused APIs. |
Jetz72
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose LandType count for custom cards.