Use devicePixelRatio for rive in app #1439
Merged
+224
−247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
@aerofoil/rive-solid-canvasdoesn't support Rive's useDevicePixelRatio, this PR adds a wrapper function to manually call the proper function which makes Rive use the dpr for higher quality drawing.Summary by CodeRabbit
Dependencies
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.
Note
Improves Rive rendering quality by ensuring the canvas matches device pixel ratio and streamlines Rive usage.
utils/riveexportscreateRiveand callsrive().resizeDrawingSurfaceToCanvas()for DPR-aware drawingsettings/license.tsxandupgrade.tsxto importcreateRivefrom~/utils/rive@rive-app/canvasto^2.32.2inapps/desktop/package.json(lockfile updated)Written by Cursor Bugbot for commit 14002da. This will update automatically on new commits. Configure here.